Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Animation to JsonEA Converter" to "Animation to JSON Converter" #602

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

Gaming32
Copy link
Contributor

Switch the "Animation to JsonEA Converter" plugin to "Animation to JSON Converter". The original library isn't really updated anymore, and I have PRed its functionality into the NeoForge mod loader instead.

@Gaming32 Gaming32 changed the title Move Move "Animation to JsonEA Converter" to "Animation to JSON Converter" Aug 20, 2024
@Gaming32
Copy link
Contributor Author

Gaming32 commented Sep 5, 2024

The NeoForge PR has now been merged.

@JannisX11
Copy link
Owner

Looks good. Please keep in mind that by changing the plugin ID, you are creating a new plugin and deleting the old one. Meaning users will have to re-install the plugin. Is that intended?

@Gaming32
Copy link
Contributor Author

I am aware of the need to reinstall, yes, but the old ID is entirely defunct, as the mod referenced in the old ID hasn't been updated in over a year.

@JannisX11 JannisX11 merged commit 3cf41fb into JannisX11:master Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants