JSON Entity Animations

[Gaming32]

This adds support for entity animations written in JSON. There is an existing Blockbench plugin to export in this format.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[ChampionAsh5357]

Thank you for the contribution! I believe this needs some work to make it more supportive of additional features that modders could use.

[ChampionAsh5357]

Very nice! Mainly just documentation comments.

[Gaming32]

Maybe you could also add support for json entity models?

That is completely out of scope for this PR.

[neoforged-automation]

@Gaming32, this pull request has conflicts, please resolve them for this PR to move forward.

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.1.42.

[Tslat]

uhhhh

You used the same asset folder as GeckoLib, and this is now causing the game to absolutely spew errors when GeckoLib animations are present

com.google.gson.JsonParseException: Not a json array: {"misc.idle":{"loop":true,"animation_length":3.52,"anim_time_update":"0","blend_weight":"1","bone......... etc.

[lukebemish]

I feel like both this and geckolib should be using appropriately namespaced asset folders -- neoforge/animations/entity and geckolib/animations/entity. Yes, changing that on the neo end is technically a breaking change but if neo broke geckolib then the original change was also breaking, so it's fine to break to fix the original break.

[dhyces]

I feel like both this and geckolib should be using appropriately namespaced asset folders -- neoforge/animations/entity and geckolib/animations/entity. Yes, changing that on the neo end is technically a breaking change but if neo broke geckolib then the original change was also breaking, so it's fine to break to fix the original break.

Geckolib should have been using a namespaced directory, yes. Neoforge apparently does not care as evidenced by datamaps using a non-namespaced folder.

[lukebemish]

Datamaps are namespaced, however -- they're namespaced by the thing actually registering the datamap, just like registries Apparently i misspoke. That's... Really terrible, wow. Those should also be namespaced I feel like...

[lukebemish]

Just following up on that -- datamaps are namespaced and that namespace is obeyed, neo just sticks its own datamaps in the default namespace for some reason. I misunderstood what was going on it seems -- data maps are, indeed, namespaced.

[Gaming32]

I feel like both this and geckolib should be using appropriately namespaced asset folders -- neoforge/animations/entity and geckolib/animations/entity. Yes, changing that on the neo end is technically a breaking change but if neo broke geckolib then the original change was also breaking, so it's fine to break to fix the original break.

As I would like to PR this same feature to Fabric, it would be ideal if the directory was not put under "neoforge". If it was, it would be extremely inconvenient to both resourcepack developers and multiloader mod developers.

[lukebemish]

Unless we can guarantee that fabric and neo would keep the same format and features for the feature, like they're in theory supposed to for convention tags, that's really irrelevant -- I do not believe that conversation has happened yet.

[TelepathicGrunt]

Linking relevant Blockbench plugin PR that modders will be able to use to get the json for NeoForge to load:
JannisX11/blockbench-plugins#602