Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minSuccess arguments from remaining tests #3981

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

FlorianHockmann
Copy link
Member

Follow-up to #3961 where I forgot to remove this argument from these 2 tests because they are using ParameterizedRepeatedIfExceptionsTest instead of RepeatedIfExceptionsTest.

This could have been a CTR commit, but unfortunately pushing directly to master doesn't work any more due to the required checks we have in place (which we need for the auto-merge feature).

Follow-up to #3961 where I forgot to remove this argument from these 2
tests because they are using `ParameterizedRepeatedIfExceptionsTest`
instead of `RepeatedIfExceptionsTest`.

Signed-off-by: Florian Hockmann <[email protected]>
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Sep 14, 2023
@FlorianHockmann FlorianHockmann enabled auto-merge (rebase) September 14, 2023 10:34
@FlorianHockmann FlorianHockmann merged commit 69ca01d into master Sep 14, 2023
208 checks passed
@FlorianHockmann FlorianHockmann deleted the Issue_3961_FollowUp branch September 15, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA testing/flaky
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants