add fb_team_match_stats and understat_available_teams functions

[shufinskiy]

@JaseZiv hello.

I create two functions for package:

1. fb_team_match_stats - return main team stats in match.
   

2. understat_available_teams - return all available teams names for selected league. Helper function, the results of which can be passed to function understat_team_meta

[JaseZiv]

How would this function scale across seasons? Hard coding team names means every season this would need to be re-done?

I don't love this function tbh

[shufinskiy]

I understand you. I found an option how to do this without hard coding.

understat_available_teams <- function(leagues){
  correct_leagues <- c("EPL", "La liga", "Bundesliga", "Serie A", "Ligue 1", "RFPL")

  teams_list <- list()

  for(lg in leagues){
    if(!lg %in% correct_leagues){warning(glue::glue("League {lg} not found. Please check understats.com for the correct league name")); next}
    match_url <- switch (lg,
                         'EPL' = 'https://understat.com/team/Arsenal',
                         'La liga' = 'https://understat.com/team/Barcelona',
                         'Bundesliga' = 'https://understat.com/team/Bayern_Munich',
                         'Serie A' = 'https://understat.com/team/AC_Milan',
                         'Ligue 1' = 'https://understat.com/team/Paris_Saint_Germain',
                         'RFPL' = 'https://understat.com/team/Spartak_Moscow'
    )
    team_page <- tryCatch(.load_page(match_url), error = function(e) NA)
    teams_list[[lg]] <- team_page %>% rvest::html_nodes(".header-wrapper") %>% html_text() %>% gsub("([\n\t])|(\\d{4}/\\d{4})", "", .) %>% gsub('(?<!\\s)([[:upper:]])', '(&&)\\1', ., perl = TRUE) %>%
      strsplit(., "\\(&&\\)", perl = TRUE) %>% unlist(.) %>% .[2:length(.)] %>%  unlist(.)
  }
  if(length(leagues) == 1){
    return(unlist(teams_list, use.names = FALSE))
  }

  return(teams_list)
}

[shufinskiy]

@JaseZiv

[JaseZiv]

I've been thinking about this for the last few days... I just think it feels a little out of place in worldfootballR, but happy to keep it in place for now

[tonyelhabr]

looks pretty good overall. in the future, i would love to see this for this to be split across 2 PRs (1 for each new function). no need to change this PR.

two requests:

1. can you add usage to the vignettes?
2. can you add tests?

[tonyelhabr]

bumped the package version and added an entry to the news file to get this past the finish line 👍

[JaseZiv]

lgtm