Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fb_team_match_stats and understat_available_teams functions #320
add fb_team_match_stats and understat_available_teams functions #320
Changes from 9 commits
7d854ac
2683fdc
9bf1cd3
33f77d8
8f6b19a
93e6853
24b08f4
c9521b9
f931160
cc74904
a179711
0a06176
0ad7e65
5f6d592
4b1795e
f0ac3bf
e5f422f
8a9e94e
6effce2
01dc879
922df25
f9407f8
c2552c2
ce40ada
74bb8bf
2d6c013
970b5a3
da77cfc
0193fa6
836a659
dea46e7
81feb08
541efdb
3e81881
e37d59c
703e8f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this function scale across seasons? Hard coding team names means every season this would need to be re-done?
I don't love this function tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand you. I found an option how to do this without hard coding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JaseZiv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking about this for the last few days... I just think it feels a little out of place in worldfootballR, but happy to keep it in place for now
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.