Fix create draft release #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-rushton
commented
Dec 31, 2023
build.gradle.kts
Outdated
| @@ -126,6 +126,6 @@ tasks { | |||
| // The pluginVersion is based on the SemVer (https://semver.org) and supports pre-release labels, like 2.1.7-alpha.3 | |||
| // Specify pre-release label to publish the plugin in a custom Release Channel automatically. Read more: | |||
| // https://plugins.jetbrains.com/docs/intellij/deployment.html#specifying-a-release-channel | |||
| channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.').first()) } | |||
| channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.')[0]) } | |||
There was a problem hiding this comment.
Another possibility I thought of could be
Suggested change
| channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.')[0]) } | |
| channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.').getOrElse(0) {"default"}) } |
but it feels a little redundant.
…le.properties` file
|
Thanks! |
hsz
added a commit
to achmyr/intellij-platform-plugin-template
that referenced
this pull request
Feb 20, 2024
* Fix bash variable access in Create Release Draft step. * Fix channels assignment in publishPlugin task. * Remove Gradle Kotlin DSL Lazy Property Assignment because it's default now * Changelog update - v1.11.3 * Remove Gradle Kotlin DSL Lazy Property Assignment from the main `gradle.properties` file * CHANGELOG update * Adjust obtaining the value for `publishPlugin.channels` property. * CHANGELOG update --------- Co-authored-by: kotlinisland <asdf> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jakub Chrzanowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I recently upgraded the build tooling in a plugin I maintain using the template as a guide. I noticed a couple of issues with the boilerplate provided.
channelsassignment in thepublishPlugintask due to the use of.first().1is pretty self explanatory but for2, changing it to[0]fixes it but it is a less than ideal solution even though the default is set previously so it can likely no error.Happy to drop this fix or change it to a recommendation. I think this is due to me using gradle 8.5 but I am not familiar enough with these tools to say for sure.
Example error