Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create draft release #427

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Fix create draft release #427

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
74ed73f
Fix bash variable access in Create Release Draft step.
ryan-rushton Dec 31, 2023
a8f6574
Fix channels assignment in publishPlugin task.
ryan-rushton Dec 31, 2023
f2c97a6
Remove Gradle Kotlin DSL Lazy Property Assignment because it's defaul…
Dec 13, 2023
cd54008
Changelog update - v1.11.3
actions-user Dec 1, 2023
d92a59a
Remove Gradle Kotlin DSL Lazy Property Assignment from the main `grad…
hsz Feb 1, 2024
1759e19
CHANGELOG update
hsz Feb 1, 2024
2d9f881
Adjust obtaining the value for `publishPlugin.channels` property.
hsz Feb 1, 2024
c7e7dba
CHANGELOG update
hsz Feb 1, 2024
41abda2
Merge branch 'next' into fix-create-draft-release
hsz Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
gh release create v${{ needs.build.outputs.version }} \
gh release create "v${{ needs.build.outputs.version }}" \
--draft \
--title "v${{ needs.build.outputs.version }}" \
--notes "$(cat << 'EOM'
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,6 @@ tasks {
// The pluginVersion is based on the SemVer (https://semver.org) and supports pre-release labels, like 2.1.7-alpha.3
// Specify pre-release label to publish the plugin in a custom Release Channel automatically. Read more:
// https://plugins.jetbrains.com/docs/intellij/deployment.html#specifying-a-release-channel
channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.').first()) }
channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.')[0]) }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another possibility I thought of could be

Suggested change
channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.')[0]) }
channels = properties("pluginVersion").map { listOf(it.split('-').getOrElse(1) { "default" }.split('.').getOrElse(0) {"default"}) }

but it feels a little redundant.

}
}