CI: Split off lint as a separate job and add shellcheck #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I certainly have no objection to this, but are you sure that lint result doesn't depend on Py version (also it's quick, isn't it?). |
Should depend on flake8 and shellcheck version, not Python version. |
|
This could be unified with #1640 probably, as that also is a lint, just for OpenAPI spec. And spinning up new Ubuntu machine takes some time that could be avoided. |
kristapsk
force-pushed
the
ci-split-lint
branch
from
f41b369
to
eada741
Compare
|
Rebased. |
OTOH, it's only 15 seconds, not much compared to total CI time. Probably better to not hurry with this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in running lint scripts on all OS / Python combinations. Saves some CI minutes.