Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use py-actions/flake8 #1475

Closed
wants to merge 1 commit into from
Closed

CI: Use py-actions/flake8 #1475

wants to merge 1 commit into from

Conversation

kristapsk
Copy link
Member

I have hope this could lower random CI failure ratio.

@kristapsk
Copy link
Member Author

Test failure was unrelated to this change, it happened after lint step.

@AdamISZ
Copy link
Member

AdamISZ commented Apr 19, 2023

What's the functional difference with triggering the lint this way instead of the old way?

@AdamISZ
Copy link
Member

AdamISZ commented Apr 19, 2023

Oh, and how does this relate/compare to #1417 ?

@kristapsk
Copy link
Member Author

kristapsk commented Apr 19, 2023 •
edited
Loading

What's the functional difference with triggering the lint this way instead of the old way?

It uses system wide install of flake8 instead of using jmvenv, so I have hope it might help with this error:

Run ./jmvenv/bin/flake8 -v jmclient jmbase jmbitcoin jmdaemon scripts
/home/runner/work/_temp/9fac98fe-de73-470b-a628-b703c23a74db.sh: ./jmvenv/bin/flake8: /home/runner/work/joinmarket-clientserver/joinmarket-clientserver/jmvenv/bin/python3: bad interpreter: No such file or directory
Error: Process completed with exit code [12](https://github.com/JoinMarket-Org/joinmarket-clientserver/actions/runs/4745039885/jobs/8426787203#step:6:13)6.

@kristapsk kristapsk mentioned this pull request May 10, 2023
Merged
kristapsk added a commit that referenced this pull request May 13, 2023
@kristapsk
Merge #1493: CI: Remove unnecessary commands from setup joinmarket + …
b340cb1 
…virtualenv step

3c0b508 Remove unnecessary commands from setup joinmarket + virtualenv step (Kristaps Kaupe)

Pull request description:

  They are run by `install.sh`, no need to run them additionally afterwards.

  If #1475 gets merged, `./jmvenv/bin/pip install -r requirements/testing.txt` can also be removed.

Top commit has no ACKs.

Tree-SHA512: 662cfcfde0ac07f6460a0e59af3af4742eb32aa1adc7846c41b9596d4ae87eb0ac2231d438a8b3aed99a34f73d7e470dab1f7af95ba4a4bdbef35046fd75a56f
@kristapsk
Copy link
Member Author

Closing for now, #1439 seems to be solved by #1490.

@kristapsk kristapsk closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapsk @AdamISZ