Delete StaticArrays Projection tests #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 93.79% 93.91% +0.12%
==========================================
Files 14 15 +1
Lines 886 904 +18
==========================================
+ Hits 831 849 +18
Misses 55 55 ☔ View full report in Codecov by Sentry. |
avik-pal
approved these changes
Jan 16, 2024
|
PR is now open to move this to StaticArrays so i am happy to merge this, since that should be merged in short order |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion to JuliaArrays/StaticArrays.jl#1228
see that PR for full details.
the tl;dr is:
These tests were breaking because of a change made in StaticArrays to how projections work (good that's their job) away from the default behavour which is implemented in this package.
It thus no longer makes sense to test StaticArrays still has the default behavour in this package.
Since we can't influence that.
Possibly we should have some other type we use to test this?
Note: this is not quiet enough to drop StaticArrays as a dependency entirely, as it is still used to test inplace accumulation into an immuatable array.