Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal Measurement Demo #221

Closed
wants to merge 5 commits into from
Closed

Signal Measurement Demo #221

wants to merge 5 commits into from

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Oct 4, 2023

This is I think a good demo of a key capability.
Making this work should make sure a variety of more complex variations work.

I am not sure if this itself will work at all without a custom frule to get around the fact that we are working with sampled data rather than a smooth function.
So this is here to test that.

However, I am currently running into other issues, it seems we can't actually AD broadcast.

@oxinabox oxinabox changed the title Introduce Signal Measurement Demo Signal Measurement Demo Oct 4, 2023
@oxinabox oxinabox self-assigned this Oct 4, 2023
src/stage1/forward.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03e160f) 56.21% compared to head (57cffe4) 56.21%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   56.21%   56.21%           
=======================================
  Files          28       28           
  Lines        2846     2846           
=======================================
  Hits         1600     1600           
  Misses       1246     1246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Member Author

Having implemented this downstream in a very different way (using Implict function theorem, rather than on sampled space) this PR is no longer useful to me

@oxinabox oxinabox closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant