-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump compat for AbstractDifferentiation to 0.6 #228
base: main
Are you sure you want to change the base?
bump compat for AbstractDifferentiation to 0.6 #228
Conversation
1aa9fc6
to
f3dafc7
Compare
Yes, I tried this the other day. This fixes a bunch of stuff that was erroring due to getting rid of closures, |
Ok I removed the things that were marked as broken that were fixed when i last tried 0.6-DEV |
@oxinabox happy to help debug the 0.6 changes, this issue recently popped up on discourse |
Since I put this on the backburner I have completely forgotten what the more subtle broken things were. Feel free to take it over @gdalle |
I don't know anything about diffractor though, I was mostly talking about problems arising from AbstractDiff. Not sure I can help debug internals over here |
also it doesn't help that the Diffractor tests seem to be failing by default? |
I think for julia 1.10 they should be working. |
That's only mildly reassuring 🤣 |
I played with this, and it's quite weird. There's a bunch of things where if I run the tests in the REPL they work fine, but if I do |
This pull request changes the compat entry for the
AbstractDifferentiation
package from0.5
to0.5, 0.6
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.