chore(release): v2.3.0-beta #2284
Conversation
This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens).
Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics.
This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation.
Signed-off-by: onur-ozkan <[email protected]>
There was a problem hiding this comment.
LGTM from a security perspective. No new dependencies have been introduced since version 2.2.0.
The only minor issue I found is that it would be better to rename "AtomicDEX API" to "Komodo DeFi Framework" everywhere. It seems we forgot to make this change in adex-cli, so I’ve created a PR to address it: #2290.
|
Testing so far has been successful, except for 401 errors returned when trying to use/document some of the 1inch methods. |
There was a problem hiding this comment.
Testing so far has been successful, except for 401 errors returned when trying to use/document some of the 1inch methods.
This has been resolved and the required steps added to docs. Methods were functional, though I was unable to build for wasm to test in that mode. As these methods are still being worked on its not a blocker, so LGTM
onur-ozkan
added
status: pending review
status: blocked
and removed
under review
status: pending review
labels
|
Blocking the release until #2296 is merged. |
Signed-off-by: onur-ozkan <[email protected]>
|
Unblocked, planning to merge this tomorrow. KomodoPlatform/rust-libp2p@f949f65 is the only change since the last approval. |
Release notes
feat(LRAPI): add 1inch classic swap rpc: Initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens)
improvement(error-handling): main files: Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics.
fix(rpc): remove character check blocking password input: Removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords.
fix(mm2_bitcoin): don't rely on core Makes no sense to rely on core on KDF.
chore(ctx): replace gstuff constructible with oncelock Replaced Constructible from the gstuff crate with once_cell::sync::OnceCell for managing lazy-initialized values in mm_ctx for better performance and stronger thread safety.
chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli self-explanatory
chore(libp2p): k-0.52.11 bump Fixes a security (memory leak) issue.