chore(libp2p): k-0.52.11 bump #2296
Conversation
onur-ozkan
added
improvement: resource usage
onur-ozkan
force-pushed
the
libp2p-bump
branch
from
5fd6342 to
51154b0
Compare
onur-ozkan
force-pushed
the
libp2p-bump
branch
from
51154b0 to
66bd6f2
Compare
onur-ozkan
changed the title
onur-ozkan
force-pushed
the
libp2p-bump
branch
from
66bd6f2 to
9fe01c2
Compare
|
I suggest next time we first review the PR in the repository we use as a dependency, and only after it is approved, review the PR in KDF that updates the dependency version. Otherwise, its hard to track code changes, especially if force push was used. |
|
For the history, could you clarify why we dont need to check and remove topics with empty peers here? |
Sure, this is the first time our team decided to make review on libp2p changes, so I didn't know you guys wanted to make review on that.
No big reason. @mariocynicys said doing that on disconnection should be enough and I didn't wanted to argue as it's not worth to discuss over that. Both are fine IMO. |
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
libp2p-bump
branch
from
9fe01c2 to
7907b83
Compare
onur-ozkan
changed the title
|
@mariocynicys if you think there are more places of improvements, I suggest you to open PR in https://github.com/KomodoPlatform/rust-libp2p/tree/debugging |
@onur-ozkan does the libp2p fix cover this case? |
|
Why would they delete topics if they are connected to each other? |
|
in light of the original issue: #771 if the |
|
No it does not. Seed nodes do not subscribe/unsubscribe to topics. In your scenario seed nodes would only have maker and taker on the topic records without including the seed nodes. |
|
aha clear thanks |
* feat(LRAPI): add 1inch classic swap rpc (#2222) This commit adds initial code to connect to 1inch Liquidity Routing API (LRAPI) provider and two new RPCs to use 1inch classic swap API. It also adds 'approve' and 'allowance' RPCs (for ERC20 tokens). * chore(release): bump mm2 version to 2.3.0-beta (#2285) * improvement(error-handling): main files (#2288) Makes KDF to check main files (config/coins/etc..) before reading them to prevent potential panics. * fix(rpc): remove character check blocking password input (#2287) This commit removes check for <, >, & characters in RPC request bodies that was incorrectly blocking valid password characters in get_mnemonic RPC call. These special characters should be allowed in passwords. This aligns native behavior with WASM implementation. * don't rely on core (#2289) Signed-off-by: onur-ozkan <[email protected]> * chore(ctx): replace gstuff constructible with oncelock (#2267) * chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (#2290) * bump libp2p (#2296) Signed-off-by: onur-ozkan <[email protected]> --------- Signed-off-by: onur-ozkan <[email protected]> Co-authored-by: dimxy <[email protected]> Co-authored-by: Onur Özkan <[email protected]> Co-authored-by: Samuel Onoja <[email protected]> Co-authored-by: DeckerSU <[email protected]>
Bumps libp2p to include KomodoPlatform/rust-libp2p@f949f65 for security reasons.
Fixes #771
Blocker for the next release.