fix(entities-routes): invisible expressions editor sometimes #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekolab
reviewed
Nov 26, 2024
| @@ -97,19 +98,19 @@ export interface ExpressionsRouteStateFields { | |||
| } | |||
|
|
|||
| export interface RouteState<Fields extends BaseRouteStateFields> { | |||
| routeFlavors: RouteFlavors // For better type narrowing | |||
| routeFlavors: MaybeRef<RouteFlavors> // For better type narrowing | |||
There was a problem hiding this comment.
The MaybeRef is not necessary here, reactive() will automatically unwrap the ref during the creating stage
There was a problem hiding this comment.
MaybeRef was for the input type of reactive(...), but I have moved away from the implicit ref unwrapping mechanism and will explicitly update the state with a watcher.
Leopoldthecoder
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where the expressions editor became invisible sometimes
KM-737