Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-routes): invisible expressions editor sometimes #1814

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix(entities-routes): invisible expressions editor sometimes #1814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76a2631
fix(entities-routes): invisible expressions editor sometimes
sumimakito Nov 26, 2024
1a922fb
fix: use watch instead of the implicit reactivity
sumimakito Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/entities/entities-routes/src/components/RouteForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ const state = reactive<RouteState<BaseRouteStateFields>>({
tags: '',
service_id: '',
...{
...(!props.routeId && { paths: [''] }),
...(!props.routeId && { paths: [''] }), // We don't expect this prop to be updated throughout the lifecycle of the component
regex_priority: 0,
path_handling: 'v0',
} as TraditionalRouteStateFields,
Expand All @@ -673,6 +673,10 @@ const state = reactive<RouteState<BaseRouteStateFields>>({
errorMessage: '',
})

watch(() => props.routeFlavors, (routeFlavors) => {
state.routeFlavors = routeFlavors
})

const exprEditorProtocol = computed(() => state.fields.protocols.split(',')[0])

const customMethods = ref<string[]>([''])
Expand Down
2 changes: 1 addition & 1 deletion packages/entities/entities-routes/src/types/route-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { BaseFormConfig, KongManagerBaseFormConfig, KonnectBaseFormConfig } from '@kong-ui-public/entities-shared'
import type { RouteLocationRaw } from 'vue-router'
import type { Methods, Method } from './method-badge'
import type { Method, Methods } from './method-badge'

export enum RouteFlavor {
TRADITIONAL = 'traditional', // includes traditional_compatible
Expand Down
Loading