This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Update cert manager crds #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all cached helm chart directories from config during cleanup (make clean or make local-cleanup). There is a bug in kustomize where the helm chart chached locally is never updated when the version of the chart in the kustomization is changed. This could potentially lead to different versions being used locally in development and running the quick start.
Update the cached cert-manager crds to the correct version (1.12.2) and updated integration tests to use this version of the crds. Adds a basic script that can be used to download the desired crds (config/cert-manager/update-crds.sh).
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
mikenairn
commented
Sep 20, 2023
Remove crd/v1.12.2 and update script Update crds (v1.12.2)
mikenairn
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
Merged
|
/lgtm given its surface area doesn't actually impact the component, I think this could get passed the freeze - @maleck13 wdyt? |
|
/lgtm |
maleck13
approved these changes
Sep 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maleck13, mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove cached helm charts during cleanup
Removes all cached helm chart directories from config during cleanup (make clean or make local-cleanup).
There is a bug in kustomize where the helm chart cached locally is never updated when the version of the chart in the kustomization is changed. This could potentially lead to different versions being used locally in development and running the quick start.
Update cached crd versions (v1.7.1 -> 1.12.2)
Update the cached cert-manager crds to the correct version (1.12.2) and updated integration tests to use this version of the crds.
Adds a basic script that can be used to download the desired crds (config/cert-manager/update-crds.sh).