MRI-adaptivity #564
MRI-adaptivity #564
Conversation
drreynolds
requested review from
balos1,
gardner48 and
cswoodward
as code owners
Co-authored-by: David Gardner <[email protected]>
Co-authored-by: David Gardner <[email protected]>
Co-authored-by: David Gardner <[email protected]>
There was a problem hiding this comment.
@gardner48: I accepted your more obvious suggestions, but I have questions about others (see comments below).
| potentially get inner dsm on all non-embedding stages */ | ||
| /* Reset the inner stepper on the first stage within all but the | ||
| first stage group due to "stage-restart" structure */ | ||
| if ((stage > 1) && (is == 0)) |
There was a problem hiding this comment.
I believe so, yes.
…pendently of the FullRHS function) to simplify the various takestep routines
…function, it cannot specify the ARK_INTERP_HERMITE module.
…llocated (e.g., after a ReInit), then free it from memory
…hematically correct. This causes some updated .out files to fail because the statistics actually return to original MRIStep behavior.
|
@gardner48 and @Steven-Roberts: I believe that I've addressed all of David's comments, but I'm about to board a plane so I can't merge with |
| if (argc > 2) udata.Npart = (int)atoi(argv[2]); | ||
| if (argc > 3) udata.G = (sunrealtype)atof(argv[3]); | ||
| if (argc > 4) udata.e = (sunrealtype)atof(argv[4]); | ||
| if (argc > 5) udata.omega = (sunrealtype)atof(argv[5]); |
There was a problem hiding this comment.
| if (argc > 2) udata.Npart = (int)atoi(argv[2]); | |
| if (argc > 3) udata.G = (sunrealtype)atof(argv[3]); | |
| if (argc > 4) udata.e = (sunrealtype)atof(argv[4]); | |
| if (argc > 5) udata.omega = (sunrealtype)atof(argv[5]); | |
| if (argc > 2) udata.Npart = atoi(argv[2]); | |
| if (argc > 3) udata.G = SUNStrToReal(argv[3]); | |
| if (argc > 4) udata.e = SUNStrToReal(argv[4]); | |
| if (argc > 5) udata.omega = SUNStrToReal(argv[5]); |
Same in the other new unit test files, but I won't duplicate this comment
| where :math:`\Delta c_i^S=\left(c^S_i - c^S_{i-1}\right)`, :math:`\tau = (t - | ||
| t_{n,i-1}^S)/(h^S \Delta c_i^S)` is the normalized time, the coefficients | ||
| :math:`\omega_{i,j}` and :math:`\gamma_{i,j}` are polynomials in time of degree | ||
| :math:`k` given by |
There was a problem hiding this comment.
In this section k is used as both the degree (a fixed constant) and an index variable which could be a bit confusing. Using two variables may help
|
|
||
| A explicit MERK method (does not support a slow implicit operator, :math:`f^I`). | ||
|
|
||
| .. c:enumerator:: MRISTEP_MRISR |
There was a problem hiding this comment.
Having MRI twice in the name seems somewhat redundant. Perhaps just MRISTEP_SR?
I think that this PR is now ready for full review.
Note: I removed all of the changesets that I'd pulled from @Steven-Roberts's PR #547 to simplify the review process for this PR.