Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRI-adaptivity #564

Open
wants to merge 301 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
301 commits
Select commit Hold shift + click to select a range
7a38980
Formatting
drreynolds Sep 6, 2024
816a24f
Resolved unused-variable 'errors'
drreynolds Sep 6, 2024
5df8989
Resolved unused-function 'errors'
drreynolds Sep 6, 2024
f99701a
Resolved unused-function 'error'
drreynolds Sep 6, 2024
8f19d24
Resolved conversion 'error'
drreynolds Sep 6, 2024
628cffc
Formatting
drreynolds Sep 6, 2024
6b9764c
Moved some new examples and unit tests to require double precision
drreynolds Sep 6, 2024
395db4b
Formatting
drreynolds Sep 6, 2024
6fc56ee
Moved a few more examples to require double precision
drreynolds Sep 6, 2024
d289163
Fixed bug wherein MRI-GARK methods mistakenly 'reset' the inner solve…
drreynolds Sep 8, 2024
6f4cb69
Updated changelog to include fix for loading default higher-order IME…
drreynolds Sep 10, 2024
330fe7b
Updated answer repository branch/commit
drreynolds Sep 10, 2024
afbb409
Merge branch 'feature/mri-adaptivity' of github.com:LLNL/sundials int…
drreynolds Sep 10, 2024
61f387d
Merged upstream changes from develop
drreynolds Sep 11, 2024
13ebccb
Fixed duplicate documentation label
drreynolds Sep 11, 2024
d518dd1
Fixed missing line to set fn_is_current to SUNTRUE
drreynolds Sep 11, 2024
55ad08f
Updated submodule commit
drreynolds Sep 11, 2024
2002f47
Merge branch 'feature/mri-adaptivity' of github.com:LLNL/sundials int…
drreynolds Sep 11, 2024
f96bef8
Updated submodule commit
drreynolds Sep 11, 2024
e321e32
Updated handling for inclusion of test_utilities.hpp file
drreynolds Sep 11, 2024
47ae44d
Added test/unit_tests/utilities to scripts/shared
drreynolds Sep 11, 2024
9607c86
update output files
gardner48 Sep 12, 2024
3f24c50
Merged in changes from develop
drreynolds Sep 12, 2024
f30ebc8
Moved check for controller type to only occur for adaptive runs
drreynolds Sep 12, 2024
4269e12
minor fix
drreynolds Sep 12, 2024
8d6dc7c
formatting
drreynolds Sep 12, 2024
e47f0d8
Merged in changes from develop
drreynolds Sep 17, 2024
8729ed2
Fixed error in ark_brusselator1D_FEM_sludist (needed to initialize th…
drreynolds Sep 19, 2024
2f75492
Updated answers repository commit
drreynolds Sep 20, 2024
ab5f57c
Added guard against one extraneous fullrhs call
drreynolds Sep 20, 2024
61f4ee4
update output files
gardner48 Sep 20, 2024
54617b5
update f2003 outputs
gardner48 Sep 20, 2024
502b9bf
Added MERK and IMEX-MRI-SR methods to recent changes files
drreynolds Sep 26, 2024
cfda92a
Applied changes suggested in code review
drreynolds Sep 26, 2024
b26c39f
Applied changes suggested in code review
drreynolds Sep 26, 2024
d46fb9a
Applied changes suggested in code review
drreynolds Sep 26, 2024
1b8df49
Applied suggestions from code review
drreynolds Sep 26, 2024
c465dbb
Minor documentation fix
drreynolds Sep 26, 2024
309f08b
Added embedding for Ralston 3 method
drreynolds Sep 26, 2024
8128a45
Updated examples according to PR recommendations
drreynolds Sep 27, 2024
d745a8f
Formatting
drreynolds Sep 27, 2024
4a03716
Updated answers submodule
drreynolds Sep 27, 2024
cc4073c
Updated answers submodule
drreynolds Sep 27, 2024
7646b29
Converted accumulated error options to an enumerated type
drreynolds Sep 27, 2024
a036591
Reverted some examples back to run on single-precision CI jobs
drreynolds Sep 27, 2024
a70c4ee
formatting
drreynolds Sep 27, 2024
45da294
Bugfix from conversion of AccumErrorType to enum
drreynolds Sep 27, 2024
9af8d3b
Formatting
drreynolds Sep 27, 2024
acf992b
Documentation fixes
drreynolds Sep 27, 2024
6c72290
Fixed one more bug in changing accumulated error type to enum; create…
drreynolds Sep 27, 2024
c808278
Updated some .out files
drreynolds Sep 27, 2024
a58e21f
Formatting; swig
drreynolds Sep 27, 2024
69cb926
Apparently I have to run swig twice?
drreynolds Sep 27, 2024
4d112cd
Updated answers submodule
drreynolds Sep 27, 2024
d31ead7
Updated answers submodule
drreynolds Sep 27, 2024
bf8ec98
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Sep 27, 2024
6affbc0
Reverted one more test to be included in the single-precision CI tests
drreynolds Sep 27, 2024
1d840da
Removed that single-precision CI test since it fails due to insuffici…
drreynolds Sep 27, 2024
5cb6f3e
Converted first argument of ARKTimestepSetForcingFn to ARKodeMem type…
drreynolds Sep 28, 2024
ccb8b63
Updated documentation formatting for custom MRI inner stepper function
drreynolds Sep 28, 2024
7abffc4
Fixed copy/paste error for version where ARKodeCreateMRIStepInnerStep…
drreynolds Sep 28, 2024
b1ddb1d
Fixed erroneous return
drreynolds Sep 28, 2024
96926e7
formatting
drreynolds Sep 28, 2024
adccf33
Merge branch 'develop' into feature/mri-adaptivity
gardner48 Oct 1, 2024
a35f336
Updated SUNAdaptController_MRIHTol structure to remove leading unders…
drreynolds Oct 1, 2024
49fc004
Removed MRIStepSetAdaptController (converted to internal arkode stepp…
drreynolds Oct 1, 2024
ddaa953
Minor documentation fixes
drreynolds Oct 1, 2024
f0c53cb
Minor documentation fix
drreynolds Oct 1, 2024
3ac7812
formatting
drreynolds Oct 1, 2024
2ecafeb
Removed unused variables
drreynolds Oct 1, 2024
fbc48bd
Removed unused variables
drreynolds Oct 1, 2024
ed75b3e
Table formatting fix
drreynolds Oct 1, 2024
f9886a2
Minor formatting fixes
drreynolds Oct 1, 2024
bba4dd8
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Oct 2, 2024
b1379e8
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Oct 2, 2024
5e576ee
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Oct 3, 2024
ffbe805
Applied suggestions from code review
drreynolds Oct 4, 2024
c445608
Apply suggestion from code review
drreynolds Oct 4, 2024
a017c07
Fix formatting introduced in PR suggestion
drreynolds Oct 4, 2024
e5c2801
Updated answers repository commit
drreynolds Oct 4, 2024
884b78d
Added comment regarding order of MERK54 method
drreynolds Oct 4, 2024
bb0dc39
Changed default embedded second-order MRI-GARK method to ARKODE_MRI_G…
drreynolds Oct 4, 2024
cc2f2a2
Swig
drreynolds Oct 4, 2024
c4d0b27
Fixed docs build error (apparently, you cannot :cite: inside a table …
drreynolds Oct 4, 2024
af9205e
revise MRIStep mathmatics section
gardner48 Oct 4, 2024
0419c3a
notational consistency
gardner48 Oct 4, 2024
3e09545
wrap long line
gardner48 Oct 4, 2024
a32deb6
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Oct 10, 2024
99d76b7
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Oct 14, 2024
c05a779
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Oct 15, 2024
69b7e98
Merged with upstream changes to develop
drreynolds Oct 15, 2024
963ddf8
bugfix (to resolve change added in PR revisions)
drreynolds Oct 20, 2024
2af1f57
Minor parameter update
drreynolds Oct 20, 2024
f977107
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Oct 21, 2024
664ac54
Added alias
drreynolds Oct 22, 2024
67f02c0
Manual fixes from code review
drreynolds Oct 22, 2024
a2e416a
Apply documentation suggestions from code review
drreynolds Oct 22, 2024
3ac13b4
Apply documentation suggestions from code review (next batch)
drreynolds Oct 22, 2024
5b0a1b7
merged
drreynolds Oct 22, 2024
4ff54b3
Manually applied suggestions from code review
drreynolds Oct 22, 2024
8953eb6
Manually applied suggestions from code review
drreynolds Oct 22, 2024
d9869d7
Manually applied suggestions from code review
drreynolds Oct 22, 2024
b404763
Manually applied suggestions from code review
drreynolds Oct 22, 2024
e72ec14
Apply suggestions from code review
drreynolds Oct 22, 2024
4e1d9fc
Initial work on addressing PR comments in code
drreynolds Oct 22, 2024
d7f961b
Updated Swig interfaces
drreynolds Oct 22, 2024
479e505
Updated Swig interfaces
drreynolds Oct 22, 2024
3ce6435
Reverted ARKODE_MRIType back to MRISTEP_METHOD_TYPE
drreynolds Oct 22, 2024
3c94fba
Removed step_supports_forcing flag from ARKODE memory structure
drreynolds Oct 22, 2024
b64f62f
Fixed 'apply suggestion' errors
drreynolds Oct 22, 2024
422db6b
Fixed conversion 'error'
drreynolds Oct 22, 2024
07bea45
Updated exposition on IMEX-MRI-SR and MERK methods (as per PR request)
drreynolds Oct 22, 2024
e5645fe
Formatting and spelling
drreynolds Oct 23, 2024
700e47f
Fixed conversion 'error'
drreynolds Oct 23, 2024
7e4dd3f
Updated new examples/tests to use ARKodeGetNumRhs
drreynolds Oct 23, 2024
a85dffe
Removed NV_Ith_S from new unit tests
drreynolds Oct 23, 2024
2749b83
Updated answers repository commit
drreynolds Oct 23, 2024
eb2e79a
Applied review suggestions to ark_test_erkstepsetforcing.c, and added…
drreynolds Oct 23, 2024
ff1cd67
Applied suggestions from code review
drreynolds Oct 23, 2024
1b8d3a0
Updated documentation on how to set up and use adaptivity in MRIStep.
drreynolds Oct 24, 2024
0790d9d
Fixed minor typo in error message
drreynolds Oct 24, 2024
54b7be1
Updated 'average' error accumulation strategy to use timestep-weighte…
drreynolds Oct 24, 2024
041ff29
Updated MRIStep to specify a default adaptivity strategy (decoupled, …
drreynolds Oct 24, 2024
80da661
Spelling
drreynolds Oct 24, 2024
fce5035
Fixed unused variable 'error'
drreynolds Oct 24, 2024
db38359
Formatting
drreynolds Oct 24, 2024
990cb24
Removed ark_test_erkstepsetforcing
drreynolds Oct 24, 2024
704a6c0
Moved one failing ark_kpr_Mt example back to double-precision testing…
drreynolds Oct 24, 2024
69749e4
Removed one more test from single precision; updated answers repository
drreynolds Oct 24, 2024
c3f1cf3
Fixed recently-introduced bug
drreynolds Oct 24, 2024
a5526d5
Removed a few remaining NV_Ith_S
drreynolds Oct 24, 2024
36370cf
Updated answers repository commit
drreynolds Oct 24, 2024
9ef8f54
Updated error checking on input parameters as per PR review
drreynolds Oct 25, 2024
51c7c50
Updated answers repository commit
drreynolds Oct 25, 2024
f767ecd
Formatting
drreynolds Oct 25, 2024
7207552
Adding 'ark_kpr_Mt 2 -5 0 -10' back in as a single-precision test to …
drreynolds Oct 25, 2024
aac1473
Removed 'too much accuracy requested' error/warning when running in f…
drreynolds Oct 25, 2024
7f503a5
Renamed SUN_ADAPTCONTROLLER_MRI_TOL to SUN_ADAPTCONTROLLER_MRI_H_TOL
drreynolds Oct 25, 2024
8a28664
Renamed SUNAdaptController_UpdateMRITol as SUNAdaptController_MRIHTol
drreynolds Oct 25, 2024
f787627
Updated Swig interfaces
drreynolds Oct 25, 2024
84d4f0d
Bugfix from last commit
drreynolds Oct 25, 2024
1d87908
Adjusted order of initial checks in arkInitialSetup
drreynolds Oct 25, 2024
c56a229
Apply logging-related suggestions from code review to src/arkode.c
drreynolds Oct 25, 2024
5068c34
Apply logging-related, and "obvious" suggestions from code review to …
drreynolds Oct 25, 2024
5a02593
Updated Swig interfaces
drreynolds Oct 25, 2024
bb093b8
Formatting
drreynolds Oct 25, 2024
de3d2db
Removed failing single-precision test (too much accuracy requested)
drreynolds Oct 25, 2024
b5d9a82
Fixed error introduced from code suggestion
drreynolds Oct 25, 2024
2fa3ee2
Apply a few more minor/assorted suggestions from code review
drreynolds Oct 25, 2024
676535a
Applied suggestion from code review regarding vector operation error …
drreynolds Oct 25, 2024
b01b640
Renamed mriStepInnerStepper_GetError and mriStepInnerStepper_ResetErr…
drreynolds Oct 25, 2024
d450704
Merge branch 'feature/mri-adaptivity' of github.com:LLNL/sundials int…
drreynolds Oct 25, 2024
7861a5f
Removed mriStep_FastRHS
drreynolds Oct 25, 2024
a874f70
Applied suggestions from code review (primarily logging-based, plus s…
drreynolds Oct 25, 2024
bc38591
Applied documentation-related suggestions from code review.
drreynolds Oct 25, 2024
8caad59
Applied documentation-related suggestions from code review.
drreynolds Oct 25, 2024
7ea9e15
Apply suggestions from code review (CMakeLists and logging)
drreynolds Oct 25, 2024
8519221
Formatting
drreynolds Oct 26, 2024
e06b25b
Formatting
drreynolds Oct 26, 2024
0d1ccfe
Formatting
drreynolds Oct 26, 2024
455f5c7
Renamed inner_control and inner_control_new to inner_rtol_factor and…
drreynolds Oct 28, 2024
50848fd
merged with upstream changes
drreynolds Oct 28, 2024
248d3e7
Updated switch/case statement to explicitly list step routines (inste…
drreynolds Oct 28, 2024
e28b699
incorporating logging-related PR suggestion
drreynolds Oct 28, 2024
bdb9cf7
Comment update
drreynolds Oct 28, 2024
60f865b
Formatting
drreynolds Oct 28, 2024
ab183fa
Updated SUNAdaptController_SetParams_MRIHTol to handle illegal inputs…
drreynolds Oct 28, 2024
f806cdd
formatting
drreynolds Oct 28, 2024
370b391
Updated documentation to more clearly state when the MRIStepInnerGetA…
drreynolds Oct 28, 2024
1c2472a
Removed explicit copy of yn to ycur at the start of mriStep_TakeStepM…
drreynolds Oct 29, 2024
78ab7c3
Removed force_reset flag from mriStep_StageERKFast (as requested in P…
drreynolds Oct 29, 2024
be6d735
Updated inner forcing in ERKStep to match approach in ARKStep, to ens…
drreynolds Oct 30, 2024
b31b6df
Reverted changes to arkHin, arkYddNorm, and arkUpperBoundH0
drreynolds Oct 30, 2024
bc79081
Updated documentation for custom MRIStepInnerSteppers
drreynolds Oct 30, 2024
f8480f3
formatting
drreynolds Oct 30, 2024
f812758
Updated answers repository commit
drreynolds Oct 30, 2024
a419169
Merged with upstream changes
drreynolds Oct 30, 2024
9661e51
Removed tout from ark_mem structure, and added it to the stepper init…
drreynolds Oct 30, 2024
3ce03dc
Formatting
drreynolds Oct 30, 2024
3935f09
Added additional return warning if temporal error accumulation is dis…
drreynolds Oct 30, 2024
ca0efd7
Updated checks on MRI coupling tables (as per PR request).
drreynolds Oct 30, 2024
b727b03
formatting
drreynolds Oct 30, 2024
00ab53a
Updated some .out files to reflect changes arising from PR revisions
drreynolds Oct 30, 2024
c08cafa
Added fse_is_current and fsi_is_current flags to MRIStep to aid in re…
drreynolds Oct 30, 2024
bacd4d8
Adjusted structure of mriStep_TakeStepMRIGARK to perform embedded sta…
drreynolds Oct 30, 2024
9147566
formatting
drreynolds Oct 30, 2024
f16198c
Updated mriStep_TakeStepMRISR and mriStep_TakeStepMERK to eliminate i…
drreynolds Oct 30, 2024
bf07627
formatting
drreynolds Oct 30, 2024
45faa46
removed 'if' statement from inside MRISR stage loop
drreynolds Oct 30, 2024
58122a2
formatting
drreynolds Oct 30, 2024
3a7be2e
Updated answers repository commit
drreynolds Oct 31, 2024
143a7f3
Optimized interaction of mriStep_TakeStepMRISR with mriStep_ComputeIn…
drreynolds Oct 31, 2024
e510e9d
Merge branch 'feature/mri-adaptivity' of github.com:LLNL/sundials int…
drreynolds Oct 31, 2024
d2d2762
spelling
drreynolds Oct 31, 2024
e0882cf
Merge behemoth.clementshall.smu.edu:research/Sundials/mri-adaptivity …
drreynolds Oct 31, 2024
68b9562
Updated answers repository commit
drreynolds Oct 31, 2024
be75236
Updated MRIStep to allow recoverable failures from the inner solver, …
drreynolds Oct 31, 2024
333ac9f
Updated answers repository commit
drreynolds Oct 31, 2024
07ac91c
Updated ARKODE MRIStepInnerStepper interface routines to send appropr…
drreynolds Oct 31, 2024
930da2c
formatting
drreynolds Oct 31, 2024
f81c9e8
Updated answers repository commit
drreynolds Oct 31, 2024
23cbb08
Updated answers repository commit
drreynolds Oct 31, 2024
1c7db4e
Added missing return values
drreynolds Oct 31, 2024
a998610
Updated answers repository commit
drreynolds Oct 31, 2024
55704c3
Reverted changes in experimental setup to re-establish appropriate 'c…
drreynolds Nov 1, 2024
647ec53
Reverted recommended optimizations regarding inner integrator reset a…
drreynolds Nov 1, 2024
4d9c92a
Minor cleanup on ARKODE-provided MRIStepInnerStepper interface
drreynolds Nov 1, 2024
d7e6198
Updated answers repository commit
drreynolds Nov 1, 2024
8b71729
Added counter for the number of recoverable failures reported by the …
drreynolds Nov 1, 2024
0c65bfd
Merge branch 'develop' into feature/mri-adaptivity
drreynolds Nov 1, 2024
e3bd2df
Updated Swig interfaces
drreynolds Nov 1, 2024
727a8a8
Merge branch 'feature/mri-adaptivity' of github.com:LLNL/sundials int…
drreynolds Nov 1, 2024
6bc2f06
Updated answers repository commit
drreynolds Nov 1, 2024
f49cb87
Updated answers repository commit
drreynolds Nov 1, 2024
c13b9ec
Removed heuristic DSM floor for MRIStep controller interface
drreynolds Nov 2, 2024
7a1c8c2
Fixed duplicate equation label
drreynolds Nov 4, 2024
7799335
update output files
gardner48 Nov 4, 2024
b6e9ede
Added manual specification of ERK-3-3 Butcher table for fast_type == 0
drreynolds Nov 7, 2024
57c5a45
Merge branch 'feature/mri-adaptivity' of github.com:LLNL/sundials int…
drreynolds Nov 7, 2024
359ae44
Updated answers repository commit
drreynolds Nov 7, 2024
6dba236
Updated answers repository commit
drreynolds Nov 7, 2024
c019727
Apply documentation-related suggestions from code review
drreynolds Nov 18, 2024
b400ad8
Apply documentation suggestion from code review
drreynolds Nov 18, 2024
3cde505
Adjusted bounds on MRIHTol parameters according to PR comments
drreynolds Nov 18, 2024
35572be
Apply minor suggestions from code review
drreynolds Nov 18, 2024
f18f722
Comment fix
drreynolds Nov 18, 2024
c0aab9e
Updated handling of stiffly-accurate MRI stages in ARK_FULLRHS_END mode
drreynolds Nov 18, 2024
46eeed1
Fixed incorrect internal documentation regarding how the FullRHS 'mod…
drreynolds Nov 19, 2024
f9d23e1
Updated SUNAdaptController_Get*Controller_MRIHTol to return a SUNErrCode
drreynolds Nov 19, 2024
3f8b3cd
Minor documentation edits
drreynolds Nov 19, 2024
43ca35d
Added utility routine to conditionally update Fse[0] and Fsi[0] (inde…
drreynolds Nov 19, 2024
a524699
Minor updates to new mriStep_UpdateF0 routine
drreynolds Nov 20, 2024
fd49431
Fixed ark_test_innerstepper.c -- since it does not provide a FullRHS …
drreynolds Nov 20, 2024
14485ff
Guarded printing ark_mem->fn based on whether that vector is allocated
drreynolds Nov 20, 2024
3de7384
Comment update
drreynolds Nov 20, 2024
bcf4b8d
Added code to update ark_mem->fn (if allocated) from various take-ste…
drreynolds Nov 20, 2024
e293fd1
Reverted previous commit to ark_test_innerstepper.c
drreynolds Nov 20, 2024
c122289
During initialization, if ark_mem->fn will be unused but is already a…
drreynolds Nov 20, 2024
439ce0a
Comment updates
drreynolds Nov 20, 2024
7cc8c60
Accepted suggestion to reset fn_is_current when external forcing func…
drreynolds Nov 20, 2024
54e1bc4
Removed sa_stage check from ARK_FULLRHS_END case, since it is not mat…
drreynolds Nov 20, 2024
2f5d8f6
Applied minor code review suggestions from @gardner48
drreynolds Nov 28, 2024
720c407
Changed k index to \ell as suggested by @Steven-Roberts
drreynolds Nov 28, 2024
9e60c90
Renamed MRISTEP_MRISR as MRISTEP_SR as per @Steven-Roberts suggestion
drreynolds Nov 28, 2024
ae3bf51
Updated handling of command-line arguments as per @Steven-Roberts sug…
drreynolds Nov 28, 2024
e31a1e4
merged with develop
drreynolds Nov 28, 2024
39e749b
Fixed merge issues; applied formatter
drreynolds Nov 28, 2024
2995955
Formatting
drreynolds Nov 28, 2024
5e3e7b9
Updated submodule commit
drreynolds Nov 28, 2024
18ca633
Updated submodule commit
drreynolds Nov 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,21 @@ The build system has been updated to utilize the CMake LAPACK imported target
which should ease building SUNDIALS with LAPACK libraries that require setting
specific linker flags e.g., MKL.

Added support for multirate time step adaptivity controllers, based on the
recently introduced `SUNAdaptController` base class, to ARKODE's MRIStep module.
As a part of this, we added embeddings for existing MRI-GARK methods, as well as
support for embedded MERK and IMEX-MRI-SR methods. Added new default MRI methods
for temporally adaptive versus fixed-step runs. Added the function
`MRIStepGetNumInnerStepperFails` to retrieve the number of recoverable
failures reported by the MRIStepInnerStepper.

Added functionality to ARKODE to accumulate a temporal error
estimate over multiple time steps. See the routines `ARKodeSetAccumulatedErrorType`,
`ARKodeResetAccumulatedError`, and `ARKodeGetAccumulatedError` for details.

drreynolds marked this conversation as resolved.
Show resolved Hide resolved
Added a utility routine to wrap any valid ARKODE integrator for use as an MRIStep
inner stepper object, `ARKodeCreateMRIStepInnerStepper`.

### Bug Fixes

Fixed a [bug](https://github.com/LLNL/sundials/issues/581) in the sparse matrix
Expand All @@ -51,11 +66,19 @@ repeatedly.
Fixed compilation errors when building the Trilinos Teptra NVector with CUDA
support.

Fixed loading the default IMEX-MRI method if `ARKodeSetOrder` is used to specify
a third or fourth order method. Previously, the default second order method
was loaded in both cases.

Fixed a CMake configuration issue related to aliasing an `ALIAS` target when
using `ENABLE_KLU=ON` in combination with a static-only build of SuiteSparse.

### Deprecation Notices

Deprecated the ARKStep-specific utility routine for wrapping an ARKStep instance
as an MRIStep inner stepper object, `ARKStepCreateMRIStepInnerStepper`. Use
`ARKodeCreateMRIStepInnerStepper` instead.

The ARKODE stepper specific functions to retrieve the number of right-hand side
function evaluations have been deprecated. Use `ARKodeGetNumRhsEvals` instead.

Expand Down
95 changes: 65 additions & 30 deletions doc/arkode/guide/source/Constants.rst
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ contains the ARKODE output constants.
+-----------------------------------------------+------------------------------------------------------------+
| | |
+-----------------------------------------------+------------------------------------------------------------+
| **Relaxtion module input constants** | |
| **Relaxation module input constants** | |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARK_RELAX_BRENT` | Specifies Brent's method as the relaxation nonlinear |
| | solver. |
Expand Down Expand Up @@ -331,20 +331,28 @@ contains the ARKODE output constants.
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_FORWARD_EULER` | Use the forward Euler MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_ERK22b` | Use the ERK22b MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_ERK22a` | Use the ERK22a MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_ERK22b` | Use the ERK22b MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_RALSTON2` | Use the second order Ralston MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MIS_MW3` | Use the Knoth-Wolke-3 MIS method. |
| :index:`ARKODE_MIS_KW3` | Use the Knoth-Wolke-3 MIS method (non-embedded). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_ERK33a` | Use the ERK33a MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_RALSTON3` | Use the third order Ralston MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_ERK45a` | Use the ERK45a MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MERK21` | Use the MERK21 method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MERK32` | Use the MERK32 method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MERK43` | Use the MERK43 method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MERK54` | Use the MERK54 method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_BACKWARD_EULER` | Use the backward Euler MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_MRI_GARK_IRK21a` | Use the IRK21a MRI-GARK method. |
Expand All @@ -361,47 +369,74 @@ contains the ARKODE output constants.
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_IMEX_MRI_GARK_MIDPOINT` | Use the midpoint rule IMEX-MRI-GARK method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_IMEX_MRI_GARK3a` | Use the IMEX-MRI-GARK3a method. |
| :index:`ARKODE_IMEX_MRI_GARK3a` | Use the IMEX-MRI-GARK3a method (non-embedded). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_IMEX_MRI_GARK3b` | Use the IMEX-MRI-GARK3b method (non-embedded). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_IMEX_MRI_GARK3b` | Use the IMEX-MRI-GARK3b method. |
| :index:`ARKODE_IMEX_MRI_GARK4` | Use the IMEX-MRI-GARK4 method (non-embedded). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`ARKODE_IMEX_MRI_GARK4` | Use the IMEX-MRI-GARK4 method. |
| :index:`ARKODE_IMEX_MRI_SR21` | Use the IMEX-MRI-SR21 method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_EXPL_TABLE_1` | Use MRIStep's default 1st-order explicit method |
| | (MRI_GARK_FORWARD_EULER). |
| :index:`ARKODE_IMEX_MRI_SR32` | Use the IMEX-MRI-SR32 method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_EXPL_TABLE_2` | Use MRIStep's default 2nd-order explicit method |
| | (MRI_GARK_ERK22b). |
| :index:`ARKODE_IMEX_MRI_SR43` | Use the IMEX-MRI-SR43 method. |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_EXPL_TABLE_3` | Use MRIStep's default 3rd-order explicit method |
| | (MIS_MW3). |
| :index:`MRISTEP_DEFAULT_EXPL_1` | Use MRIStep's default 1st-order explicit method |
| | (ARKODE_MRI_GARK_FORWARD_EULER). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_EXPL_TABLE_4` | Use MRIStep's default 4th-order explicit method |
| | (MRI_GARK_ERK45a). |
| :index:`MRISTEP_DEFAULT_EXPL_2` | Use MRIStep's default 2nd-order explicit method |
| | (ARKODE_MRI_GARK_ERK22b). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_TABLE_1` | Use MRIStep's default 1st-order solve-decoupled implicit |
| | method (MRI_GARK_BACKWARD_EULER). |
| :index:`MRISTEP_DEFAULT_EXPL_3` | Use MRIStep's default 3rd-order explicit method |
| | (ARKODE_MIS_KW3). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_TABLE_2` | Use MRIStep's default 2nd-order solve-decoupled implicit |
| | method (MRI_GARK_IRK21a). |
| :index:`MRISTEP_DEFAULT_EXPL_4` | Use MRIStep's default 4th-order explicit method |
| | (ARKODE_MRI_GARK_ERK45a). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_TABLE_3` | Use MRIStep's default 3rd-order solve-decoupled implicit |
| | method (MRI_GARK_ESDIRK34a). |
| :index:`MRISTEP_DEFAULT_EXPL_2_AD` | Use MRIStep's default 2nd-order adaptive explicit method |
| | (ARKODE_MRI_GARK_ERK22a). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_TABLE_4` | Use MRIStep's default 4th-order solve-decoupled implicit |
| | method (MRI_GARK_ESDIRK46a). |
| :index:`MRISTEP_DEFAULT_EXPL_3_AD` | Use MRIStep's default 3rd-order adaptive explicit method |
| | (ARKODE_MRI_GARK_ERK33a). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_TABLE_1` | Use MRIStep's default 1st-order solve-decoupled ImEx |
| | method (IMEX_MRI_GARK_EULER). |
| :index:`MRISTEP_DEFAULT_EXPL_4_AD` | Use MRIStep's default 4th-order adaptive explicit method |
| | (ARKODE_MRI_GARK_ERK45a). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_TABLE_2` | Use MRIStep's default 2nd-order solve-decoupled ImEx |
| :index:`MRISTEP_DEFAULT_EXPL_5_AD` | Use MRIStep's default 5th-order adaptive explicit method |
| | (ARKODE_MERK54). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_1` | Use MRIStep's default 1st-order solve-decoupled implicit |
| | method (ARKODE_MRI_GARK_BACKWARD_EULER). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_2` | Use MRIStep's default 2nd-order solve-decoupled implicit |
| | method (ARKODE_MRI_GARK_IRK21a). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_3` | Use MRIStep's default 3rd-order solve-decoupled implicit |
| | method (ARKODE_MRI_GARK_ESDIRK34a). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMPL_SD_4` | Use MRIStep's default 4th-order solve-decoupled implicit |
| | method (ARKODE_MRI_GARK_ESDIRK46a). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_1` | Use MRIStep's default 1st-order solve-decoupled ImEx |
| | method (ARKODE_IMEX_MRI_GARK_EULER). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_2` | Use MRIStep's default 2nd-order solve-decoupled ImEx |
| | method (ARKODE_IMEX_MRI_GARK_TRAPEZOIDAL). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_TABLE_3` | Use MRIStep's default 3rd-order solve-decoupled ImEx |
| | method (IMEX_MRI_GARK3b). |
| :index:`MRISTEP_DEFAULT_IMEX_SD_3` | Use MRIStep's default 3rd-order solve-decoupled ImEx |
| | method (ARKODE_IMEX_MRI_GARK3b). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_4` | Use MRIStep's default 4th-order solve-decoupled ImEx |
| | method (ARKODE_IMEX_MRI_GARK4). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_2_AD` | Use MRIStep's default 2nd-order solve-decoupled adaptive |
| | ImEx method (ARKODE_IMEX_MRI_SR21). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_3_AD` | Use MRIStep's default 3rd-order solve-decoupled adaptive |
| | ImEx method (ARKODE_IMEX_MRI_SR32). |
+-----------------------------------------------+------------------------------------------------------------+
| :index:`MRISTEP_DEFAULT_IMEX_SD_TABLE_4` | Use MRIStep's default 4th-order solve-decoupled ImEx |
| | method (IMEX_MRI_GARK4). |
| :index:`MRISTEP_DEFAULT_IMEX_SD_4_AD` | Use MRIStep's default 4th-order solve-decoupled adaptive |
| | ImEx method (ARKODE_IMEX_MRI_SR43). |
+-----------------------------------------------+------------------------------------------------------------+


Expand Down
Loading