Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Node] Add ldlflag to build #519

Merged
merged 4 commits into from
Apr 25, 2024
Merged

[Node] Add ldlflag to build #519

merged 4 commits into from
Apr 25, 2024

Conversation

siddimore
Copy link
Contributor

Why are these changes needed?

Update Semver flag by taking it as input from github action

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore requested a review from bxue-l2 April 24, 2024 05:16
@siddimore siddimore marked this pull request as ready for review April 24, 2024 14:03
@siddimore siddimore requested review from mooselumph and dmanc April 24, 2024 14:03
dmanc
dmanc approved these changes Apr 24, 2024
View reviewed changes
node/config.go Outdated Show resolved Hide resolved
@siddimore siddimore merged commit da48cbe into Layr-Labs:master Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddimore @dmanc