Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node] Add ldlflag to build #519

Merged
merged 4 commits into from
Apr 25, 2024
Merged

[Node] Add ldlflag to build #519

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a80b04
add ldlflag to node build
Apr 24, 2024
1c0dd7c
update var
Apr 24, 2024
64e1904
Fix PR comment
Apr 24, 2024
83c6311
Fix PR comment
Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/docker-publish-opr-node-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ on:
commit_sha:
description: 'Specific Commit SHA (Required)'
required: true
version:
description: 'Version (Required)'
required: true
gitCommit:
description: 'GitCommit (Required)'
required: true
gitDate:
siddimore marked this conversation as resolved.
Show resolved Hide resolved
description: 'GitDate (Required)'
required: true
release_tag:
description: 'Release Tag (Optional)'
required: false
Expand Down Expand Up @@ -64,6 +73,7 @@ jobs:
tags: ${{ env.REGISTRY }}/layr-labs/eigenda/opr-node:${{ steps.set_tag.outputs.tag }}
cache-from: type=local,src=/tmp/.buildx-cache
cache-to: type=local,dest=/tmp/.buildx-cache-new
build-args: SEMVER=${{ github.event.inputs.version }},GITCOMMIT=${{ github.event.inputs.gitcommit }},DATE=${{ github.event.inputs.GitDate }}
if: ${{ success() }}

- name: Build and Push NodePlugin Image
Expand Down
6 changes: 5 additions & 1 deletion node/cmd/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
FROM golang:1.21.1-alpine3.18 as builder

ARG SEMVER
ARG GITCOMMIT
ARG GITDATE

RUN apk add --no-cache make musl-dev linux-headers gcc git jq bash

# build node with local monorepo go modules
Expand All @@ -16,7 +20,7 @@ COPY go.sum /app

WORKDIR /app/node

RUN go build -o ./bin/node ./cmd
RUN go build -ldflags="-X 'node.SemVer=${SEMVER}' -X 'node.GitCommit=${GITCOMMIT}' -X 'node.GitDate=${GITDATE}'" -o ./bin/node ./cmd

FROM alpine:3.18

Expand Down
6 changes: 3 additions & 3 deletions node/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ const (
// Min number of seconds for the ExpirationPollIntervalSecFlag.
minExpirationPollIntervalSec = 3
AppName = "da-node"
SemVer = "0.6.1"
GitCommit = ""
GitDate = ""
)

var (
Expand All @@ -35,6 +32,9 @@ var (
0: "eth_quorum",
1: "permissioned_quorum",
}
SemVer = "v0.0.0"
GitCommit = ""
GitDate = ""
)

// Config contains all of the configuration information for a DA node.
Expand Down
Loading