-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coin modularization / refactoring for MultiversX #7637
Conversation
Created coin module package
Moved files from ledger-live-common to new package without any modifications
Modified files to match new guidelines and moved hw-app to separate package
…lity Renamed package to old name for easier integration
Fixed ledger live imports
…ultiversx-2024-08-21 Merge develop into feat/coin-multiversx (2024-08-21)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
@andreibancioiu is attempting to deploy a commit to the LedgerHQ Team on Vercel. A member of the Team first needs to authorize it. |
...ve-mobile/src/families/elrond/components/Flows/Delegate/components/PickAmount/PickAmount.tsx
Show resolved
Hide resolved
Edit: done, ty ✅ |
The README check for hw-app-elrond is failing, here is a commit where I've generated one (using Edit: done, ty ✅ |
This change here 1891fd6 Edit: done, ty ✅ |
After all those changes I'd recommend rebasing with develop (the Ton token was integrated recently, you might have some minor conflicts). If you have problem with the pnpm-lock.yaml during rebase just add it during conflicts without fixing the merge conflicts, at the end of the rebase remove it, then launch a This should fix the e2e tests that are failing on another chain (cosmos) |
Fixes after review
Merge develop after fixes
Merge develop into feat/coin-multiversx
|
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
✅ Checklist
npx changeset
was attached.📝 Description
❓ Context
🧐 Checklist for the PR Reviewers