-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVE-8169: multiversx coin modularization #7750
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Desktop Bundle ChecksMobile Bundle Checks
|
09b5a61
to
9bed32c
Compare
[Bot] Testing with 'Nitrogen' ✅ 3 txs ($24.07) ⏲ 6min 32s
|
Spec (accounts) | State | Remaining Runs (est) | funds? |
---|---|---|---|
Elrond (8) | 2698 ops (+6), 0.932645 EGLD ($24.07) | 💪 999+ | erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp |
undefined: 0.400201 EGLD (424ops) (erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp on 44'/508'/0'/0/0) #0 js:2:elrond:erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp:
undefined: 0 EGLD (450ops) (erd172muqtk2ka5ath64284fm0av4tarkg6l040c595uswwz3tgngh9s9dtgp6 on 44'/508'/1'/0/0) #1 js:2:elrond:erd172muqtk2ka5ath64284fm0av4tarkg6l040c595uswwz3tgngh9s9dtgp6:
undefined: 0.0168842 EGLD (420ops) (erd1ql9pxrhe29cjr8qgxx3rtmh9lyax5x9dkvu3mfzrgt4e8hwk536ssl4sea on 44'/508'/2'/0/0) #2 js:2:elrond:erd1ql9pxrhe29cjr8qgxx3rtmh9lyax5x9dkvu3mfzrgt4e8hwk536ssl4sea:
undefined: 0 EGLD (406ops) (erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn on 44'/508'/3'/0/0) #3 js:2:elrond:erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn:
undefined: 0 EGLD (387ops) (erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el on 44'/508'/4'/0/0) #4 js:2:elrond:erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el:
undefined: 0.033577 EGLD (347ops) (erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n on 44'/508'/5'/0/0) #5 js:2:elrond:erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n:
undefined: 0.481758 EGLD (264ops) (erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7 on 44'/508'/6'/0/0) #6 js:2:elrond:erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7:
undefined: 0 EGLD (0ops) (erd1w4jjugkk5rp8hn8erefltjn0xek4x60t4hzsmnkfty7930sxujtqgryqgw on 44'/508'/7'/0/0) #7 js:2:elrond:erd1w4jjugkk5rp8hn8erefltjn0xek4x60t4hzsmnkfty7930sxujtqgryqgw:
Performance ⏲ 6min 32s
Time spent for each spec: (total across mutations)
Spec (accounts) | preload | scan | re-sync | tx status | sign op | broadcast | test | destination test |
---|---|---|---|---|---|---|---|---|
TOTAL | 285ms | 4min 55s | 2386ms | 7ms | 9.5s | 782ms | 37.1s | 44.8s |
Elrond (7) | 285ms | 4min 55s | 2386ms | 7ms | 9.5s | 782ms | 37.1s | 44.8s |
What is the bot and how does it work? Everything is documented here!
9bed32c
to
67c0154
Compare
88a211d
to
3b3d2aa
Compare
move files from ledger-live-common to new package wip: updating files fix files adapt files and move hw-app to separate package fixes after review fixes after review fixes update generated files change string representation to ascii for address rename to elrond for easier integration move dependency from devDependencies add missing dependency regenerate files and small comment fix update snapshot fixes after testing fix ledger live imports Update auto-generated files. Update libs/coin-modules/coin-elrond/src/bridge/js.ts Co-authored-by: Samy Rabah <[email protected]> Fix regression - passing the data field (MultiversX transactions). Bit of refactoring. Add unit tests. mobile import fixes Fix displayed amount upon performing a "delegate" operation. Add unit tests. Fix types within tests. fixes after review regenerate pnpm-lock fix pnpmlock update unimported log out flaky test
remove logs changeset
3b3d2aa
to
f0b189c
Compare
coin modularization of elrond/multiversx, some bug fixes and new unit tests
This was done by the multiversx team, I've already reviewed their original PR #7637, you can look at the comments to check what was spotted / fixed.
✅ Checklist
npx changeset
was attached.Nitrogen bot testing: ✅ #7750 (comment)
📝 Description
Main
Secondary
Flaky test fix
A flaky test on cosmos delegations (unrelated to this PR) failed the e2e tests, the fix rounds up the expected delegated value
The failing test https://github.com/LedgerHQ/ledger-live/actions/runs/10707097454/job/29686475528
The fix https://github.com/LedgerHQ/ledger-live/pull/7750/files#diff-3964b3cbce008b8eb4fd5cd3d7a24483843ee20c58ae8ea73797e1efa4479c0cR41-R44
It would take more time to properly investigate why, but my guess is, in certain case, the tested cosmos delegated value ends up in a state where rounding is done by the cosmos-sdk and gives us back a value that was rounded in a specific way. Cosmos-sdk uses bankers rounding when computing the delegated balance
https://github.com/cosmos/cosmos-sdk/blob/6b20ef7388dffe3f3938b81bc1946b7a5b072db1/x/staking/types/validator.go#L321 uses rounding up.
As for the documentation, they raise that rounding behaviour has quirks https://docs.cosmos.network/main/build/modules/auth/vesting#undelegating.
bignumber.js equivalent to rounding up is BigNumber.ROUND_CEIL
❓ Context
🧐 Checklist for the PR Reviewers