fix(llm): 🐛 fix long Memo Tag issue on Stacks #8604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
live-github-bot
bot
added
mobile
KVNLS
reviewed
Dec 4, 2024
| import type { Transaction as StacksTransaction } from "@ledgerhq/live-common/families/stacks/types"; | ||
| import type { MemoTagInputProps } from "LLM/features/MemoTag/types"; | ||
| import { GenericMemoTagInput } from "LLM/features/MemoTag/components/GenericMemoTagInput"; | ||
|
|
||
| export default (props: MemoTagInputProps<StacksTransaction>) => ( | ||
| <GenericMemoTagInput | ||
| {...props} | ||
| textToValue={text => text.slice(0, STACKS_MAX_MEMO_SIZE)} |
There was a problem hiding this comment.
Not sure if we want to have this solution, can you confirm with our PM, please?
3 tasks
thesan
changed the title
KVNLS
previously approved these changes
Dec 5, 2024
|
@KVNLS @ComradeAERGO thank you for the reviews but I will have to edit this PR because the size limit is not 34 chars is 34 bytes so the current solution doesn't work for non ASCII characters: Screen.Recording.2024-12-05.at.18.19.45.mov |
thesan
force-pushed
the
fix/llm-stacks-memo-too-long
branch
from
e71286f to
99476d0
Compare
3 tasks
KVNLS
approved these changes
Dec 6, 2024
ComradeAERGO
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Truncate Stacks memos in the input to prevent the transaction validation from failing. Follow up to #8340.
Screen.Recording.2024-12-04.at.18.28.15.mov
❓ Context
🧐 Checklist for the PR Reviewers