treat ref as string when triggering release build #8681
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
themooneer
reviewed
Dec 13, 2024
themooneer
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Fixes the issue from this failing workflow by correctly handling the ref as a string when triggering the ledger-live-build release workflows.
This issue was introduced by the work merged 2 weeks ago to update the hotfix process (PR). This final step of the release process was not tested due to the likelihood of accidentally creating release artefacts (such as a github release or actual new app builds etc). However this time around I did figure out how to test for these changes without accidentally creating a release and the test was set up in this testing PR which ran successfully ✅. That PR explains how the testing works and links to the successful run