Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEMP - fix release final script trigger test PR #8690

Closed

Conversation

angusbayley
Copy link
Contributor

@angusbayley angusbayley commented Dec 13, 2024

This is a test PR for #8681

It modifies the call to release-desktop in ledger-live-build to use the branch at https://github.com/LedgerHQ/ledger-live-build/pull/118 . This branch removes all functionality from that workflow temporarily, so we can call it to make sure the call works, without there being any downstream effects.

To run this test:

  1. manually trigger the release-final workflow in ledger-live from this branch
  2. observe that that workflow calls release-desktop in ledger-live-build
  3. ensure that it calls the branch at https://github.com/LedgerHQ/ledger-live-build/pull/118 , echoing a success message
  4. ensure that the calling process has not created any errors in the workflow from step # 1

…my-release-desktop branch

On this new branch in ledger-live-build, release-desktop is modified to do nothing
This will allow for us to run a test of ledger-live's release-final workflow to ensure that the
workflow is called correctly bu with no downstream effects
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 13, 2024 0:26am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 13, 2024 0:26am
react-ui-storybook ⬜️ Ignored (Inspect) Dec 13, 2024 0:26am
web-tools ⬜️ Ignored (Inspect) Dec 13, 2024 0:26am

@angusbayley
Copy link
Contributor Author

The test was a pass ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant