add nbgl tests workflow #822
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 35.49% 35.49%
=======================================
Files 13 13
Lines 1606 1606
=======================================
Hits 570 570
Misses 1036 1036
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tdejoigny-ledger
force-pushed
the
tdj/add_nbgl_tests
branch
6 times, most recently
from
54c7aee to
fb8bf4e
Compare
|
|
||
| jobs: | ||
| run_NBGL_tests: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Would it work more simply using something like:
jobs:
run_NBGL_tests:
uses: LedgerHQ/app-nbgl-tests/.github/workflows/build_and_functional_tests.yml@master
with:
golden_run: "Open a PR"
secrets: inherit
🤔
There was a problem hiding this comment.
yes could be interesting if it's working and if the PR can be opened in the remote repository
There was a problem hiding this comment.
https://github.com/LedgerHQ/ledger-secure-sdk/actions/runs/12199393685
It seems that this option is not working
tdejoigny-ledger
force-pushed
the
tdj/add_nbgl_tests
branch
from
24934a1 to
bd62ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.