Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nbgl tests workflow #822

Closed
wants to merge 1 commit into from
Closed

add nbgl tests workflow #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/nbgl_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Run NBGL tests

on:
push:
branches:
- master
- main
- develop
pull_request:
workflow_dispatch:

jobs:
run_NBGL_tests:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work more simply using something like:

jobs:
  run_NBGL_tests:
    uses: LedgerHQ/app-nbgl-tests/.github/workflows/build_and_functional_tests.yml@master
    with:
      golden_run: "Open a PR"
    secrets: inherit

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes could be interesting if it's working and if the PR can be opened in the remote repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/LedgerHQ/ledger-secure-sdk/actions/runs/12199393685
It seems that this option is not working

env:
GITHUB_TOKEN: ${{ secrets.CI_BOT_TOKEN }}
steps:
- name: Trigger the NBGL tests
run: |
curl -X POST \
-H "Accept: application/vnd.github.v3+json" \
-H "Authorization: token $GITHUB_TOKEN" \
https://api.github.com/repos/LedgerHQ/app-nbgl-tests/dispatches \
-d '{"event_type":"trigger-workflow","client_payload":{"inputs":{"golden_run":"Open a PR"}}}'
Loading