Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clue/FEE: Implement User and Admin Menu Dropdowns #392 #487
clue/FEE: Implement User and Admin Menu Dropdowns #392 #487
Changes from all commits
8840b9d
270fcad
8aacdcd
b8cd18b
7a38476
d4240cc
a63b39b
0a4555e
f43e026
e44a123
711bae3
cb516d6
39b2646
82d4d38
6d1f156
32a0357
43ab662
1624e58
18e7fb9
c7548a4
806ba0c
ab630c7
dc96191
131ea7c
ecfe368
1f8af16
bca6971
989eb27
bbac284
2652962
56c16c7
930b5ca
1013bfc
199a109
b2ef060
843c317
9fb7f34
52f9cb4
8ba358e
1a51303
053115e
49bb7d8
cbad1fe
993bd01
83680b5
22393ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Curious as to why AuthContextProvider is render here like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has to do with the nav needing the auth context provider to access certain functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a special button that it needs all these different class names? @ryandotfurrer Can we create a new variant for this type of button so we're not setting these classes over again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shashilo, By default, shadcn uses a different look that I needed to change to match our design (first screenshot). Shadcn's does not take up the full width (second screenshot).
I reckon we could call this variant something like "DropdownMenuToggleButton" or something along those lines to describe what it should be used for.
Figma design
shadcn default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that, but in another ticket.