Compatibility with PHP8 / Minimum PHP7.4 #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielpiriz
force-pushed
the
gsc-master-dev
branch
from
ac06622 to
7e59597
Compare
gabrielpiriz
changed the title
gabrielpiriz
changed the title
gabrielpiriz
force-pushed
the
gsc-master-dev
branch
from
7e59597 to
a41fe8b
Compare
gabrielpiriz
changed the title
nandoc2
reviewed
May 30, 2022
| @@ -1,4 +1,4 @@ | |||
| parameters: | |||
| level: 7 | |||
| level: 5 | |||
There was a problem hiding this comment.
any reason of this change? I'd suggest adding a phpstan baseline instead
There was a problem hiding this comment.
also I'd suggest to add php 8 in github actions workflow CI
|
Nice work @gabrielpiriz ! Any chance codeowners can review it? |
… into gsc-master-dev
… into gsc-master-dev
gabrielpiriz
force-pushed
the
gsc-master-dev
branch
from
075d546 to
5083e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for usage of PHP8 while still being compatible with PHP7
It comes by default with the
composer.lockfor PHP 8.Bumped dependencies and made changes according to keep
composer testworking.