Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump resources: remove calls to exit(1) #1852

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

dump resources: remove calls to exit(1) #1852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions framework/decode/vulkan_replay_dump_resources.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1876,11 +1876,8 @@ VkResult VulkanReplayDumpResourcesBase::QueueSubmit(const std::vector<VkSubmitIn
queue, index, cmd_buf_begin_map_[command_buffer_handles[o]], modified_submit_infos[s], fence);
if (res != VK_SUCCESS)
{
GFXRECON_LOG_ERROR("Dumping draw calls failed (%s). Terminating.",
util::ToString<VkResult>(res).c_str())
Release();
exit(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these means that the message is no longer true. But the message probably means that execution can't continue. Doesn't this need to terminate somehow, either by abort or throw or some such?

Copy link
Contributor

@bradgrantham-lunarg bradgrantham-lunarg Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, probably GFXRECON_LOG_FATAL, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at framework/util/logging.h, it seems there is no real difference between GFXRECON_LOG_ERROR and GFXRECON_LOG_FATAL. Do we want FATAL to terminate every time?

return res;
throw(std::runtime_error("Dumping draw calls failed: " + util::ToString<VkResult>(res)));
}

submitted = true;
Expand All @@ -1893,11 +1890,8 @@ VkResult VulkanReplayDumpResourcesBase::QueueSubmit(const std::vector<VkSubmitIn
queue, index, cmd_buf_begin_map_[command_buffer_handles[o]], modified_submit_infos[s], fence);
if (res != VK_SUCCESS)
{
GFXRECON_LOG_ERROR("Dumping dispatch/ray tracing failed (%s). Terminating.",
util::ToString<VkResult>(res).c_str())
Release();
exit(1);
return res;
throw(std::runtime_error("Dumping dispatch/ray tracing failed: " + util::ToString<VkResult>(res)));
}

submitted = true;
Expand Down
Loading