Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to yarn 3 #292

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Upgrade to yarn 3 #292

merged 1 commit into from
Oct 19, 2021

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Oct 8, 2021

@agrare
Copy link
Member

agrare commented Oct 8, 2021

@Fryguy can these be merged independently or do they have to be in lockstep with a UI PR

@miq-bot
Copy link
Member

miq-bot commented Oct 8, 2021

Checked commit Fryguy@8d63e3d with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@miq-bot
Copy link
Member

miq-bot commented Oct 8, 2021

Some comments on commit Fryguy@8d63e3d

.yarn/releases/yarn-3.0.2.cjs

  • ⚠️ - 311 - Detected pp. Remove all debugging statements.
  • ⚠️ - 312 - Detected pp. Remove all debugging statements.
  • ⚠️ - 316 - Detected pp. Remove all debugging statements.
  • ⚠️ - 382 - Detected pp. Remove all debugging statements.
  • ⚠️ - 386 - Detected pp. Remove all debugging statements.
  • ⚠️ - 435 - Detected pp. Remove all debugging statements.
  • ⚠️ - 58 - Detected pp. Remove all debugging statements.
  • ⚠️ - 99 - Detected pp. Remove all debugging statements.

@Fryguy
Copy link
Member Author

Fryguy commented Oct 19, 2021

@agrare These can technically be merged independently, but I was waiting until kavya verified. Feel free to merge.

@agrare agrare merged commit 1631a1a into ManageIQ:master Oct 19, 2021
@Fryguy Fryguy deleted the yarn3 branch October 21, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants