Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to yarn 3 #1707

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Upgrade to yarn 3 #1707

merged 3 commits into from
Oct 19, 2021

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Oct 8, 2021

Before the fixes in 980a23b, linting was silently failing, however with
the fixes, linting fails all of the time. This commit temporarily
removes the linting from the tests in order to proceed.
@miq-bot
Copy link
Member

miq-bot commented Oct 12, 2021

Some comments on commits Fryguy/manageiq-ui-service@80bec5c~...14d3f68

.yarn/releases/yarn-3.0.2.cjs

  • ⚠️ - 311 - Detected pp. Remove all debugging statements.
  • ⚠️ - 312 - Detected pp. Remove all debugging statements.
  • ⚠️ - 316 - Detected pp. Remove all debugging statements.
  • ⚠️ - 382 - Detected pp. Remove all debugging statements.
  • ⚠️ - 386 - Detected pp. Remove all debugging statements.
  • ⚠️ - 435 - Detected pp. Remove all debugging statements.
  • ⚠️ - 58 - Detected pp. Remove all debugging statements.
  • ⚠️ - 99 - Detected pp. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Oct 12, 2021

Checked commits Fryguy/manageiq-ui-service@80bec5c~...14d3f68 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@kavyanekkalapu kavyanekkalapu merged commit d113b97 into ManageIQ:master Oct 19, 2021
@Fryguy Fryguy deleted the yarn3 branch January 19, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants