[WIP] Rails71 #23225

jrafanie · 2024-10-07T22:45:09Z

No description provided.

https://www.github.com/rails/rails/pull/45908

Rails 7.1 removed the table_name alias to name so just use name: See: https://www.github.com/rails/rails/pull/46864 Rails 7.1 removed the writer for the table_alias so set the instance variable. We will need to see if there is a way to do this that's less brittle. See: https://www.github.com/rails/rails/pull/48927

See: https://www.github.com/ManageIQ/manageiq-loggers/pull/63

I don't think it fixes all the issues as you can call alias_attribute anywhere up the ancestry tree and it's possible lazy loading is preventing them from being loaded. See: https://www.github.com/rails/rails/issues/52820 https://www.github.com/rails/rails/pull/52842 (7.1 backport: https://www.github.com/rails/rails/pull/52844) Looks like it's still an issue in some situations: https://www.github.com/rails/rails/issues/50154 https://www.github.com/rails/rails/issues/51717

Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually.

I noticed deep_merge was behaving differently in tests and failing on 7.1. Digging in, rails 7.0 was using the gem, 7.1 was using the activesupport module: rails 7.1: ``` (byebug) {}.method(:deep_merge) #<Method: Hash(DeepMerge::DeepMergeHash)#deep_merge(source, options=...) /Users/joerafaniello/.gem/ruby/3.3.6/gems/deep_merge-1.2.2/lib/deep_merge/deep_merge_hash.rb:18> ``` rails 7.0: ``` (byebug) {}.method(:deep_merge) #<Method: Hash#deep_merge(other_hash, &block) /Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.0.8.6/lib/active_support/core_ext/hash/deep_merge.rb:18> ``` Rails 7.1 changed the way their deep_merge is defined via a refactored module: https://www.github.com/rails/rails/commit/43b980368a7628fac95cc4f673e0dfbcee77c10b This was raised in: https://www.github.com/rails/rails/issues/49457 Config gem fixed this in 5.0 and subsequently fixed another compatibility issue in 5.1 https://www.github.com/rubyconfig/config/commit/759c0fe271b4b90d534217a5b6e0653d0c94ee85

miq-bot · 2024-11-20T22:15:45Z

Checked commits jrafanie/manageiq@b3ed22e~...1b0c5a9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
29 files checked, 35 offenses detected

Gemfile

❗ - Line 25, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
❗ - Line 55, Col 1 - Layout/LeadingCommentSpace - Missing space after #.
❗ - Line 55, Col 2 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

app/models/automation_request.rb

❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/automation_task.rb

❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/manageiq/providers/embedded_automation_manager/authentication.rb

❗ - Line 7, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 8, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/miq_provision.rb

❗ - Line 19, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 20, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 22, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 23, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 24, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 25, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/miq_provision_request.rb

❗ - Line 5, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 6, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 7, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 8, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/persistent_volume.rb

❗ - Line 8, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 9, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/physical_switch.rb

❗ - Line 21, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 22, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/resource_group.rb

❗ - Line 16, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 17, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/service.rb

❗ - Line 108, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 109, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/service_template_provision_request.rb

❗ - Line 12, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 13, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/vm_migrate_task.rb

❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/vm_reconfigure_task.rb

❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/vm_retire_task.rb

❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

jrafanie requested a review from Fryguy as a code owner October 7, 2024 22:45

jrafanie changed the title ~~[WIPRails71~~ [WIP] Rails71 Oct 7, 2024

jrafanie added enhancement wip rails7.1 labels Oct 7, 2024

jrafanie force-pushed the rails71 branch 2 times, most recently from 8888823 to 35c7f80 Compare October 7, 2024 22:53

miq-bot added the dependencies label Oct 7, 2024

jrafanie force-pushed the rails71 branch from 534cb5d to c7e275a Compare October 8, 2024 14:17

jrafanie mentioned this pull request Oct 10, 2024

Support rails 7.1 #23200

Open

40 tasks

jrafanie force-pushed the rails71 branch from c7e275a to a1834c0 Compare October 10, 2024 17:33

jrafanie requested review from agrare and kbrock as code owners October 10, 2024 17:33

miq-bot added the unmergeable label Oct 16, 2024

jrafanie force-pushed the rails71 branch from a1834c0 to a759a77 Compare October 23, 2024 22:47

jrafanie mentioned this pull request Oct 29, 2024

Rails 4? Remove long since deprecated bridge monkey patch #23247

Merged

1 task

jrafanie force-pushed the rails71 branch 2 times, most recently from 95c915c to 728da06 Compare October 29, 2024 19:37

This was referenced Oct 30, 2024

Fix deprecations using activesupport deprecation #23249

Merged

Fix positional argument deprecations with ERB.new #23250

Merged

miq-bot removed the unmergeable label Oct 31, 2024

This was referenced Nov 1, 2024

Use the rails 7.1+ serialize interface #23253

Merged

Use Rails.application.credentials instead of deprecated secrets #23254

Merged

jrafanie force-pushed the rails71 branch from 728da06 to 72581af Compare November 7, 2024 14:47

jrafanie added 6 commits November 20, 2024 15:18

Update dependencies for rails 7.1

b3ed22e

Drop already disabled legacy option rails 7.1 disallows

05a52da

Use new interface for SchemaMigration in 7.1

fc2bcb7

https://www.github.com/rails/rails/pull/45908

Gems for rails 7.1

913bea4

WIP, use YAML as default column serializer

65c67be

jrafanie added 6 commits November 20, 2024 15:18

Change broadcast logger like we did in loggers

9e6dbfd

See: https://www.github.com/ManageIQ/manageiq-loggers/pull/63

Avoid calling MiqQueue.messaging_client and stub it as missing

2fa87db

WIP - hack - workaround alias_attribute bug for now

ef523ec

Remove alias_attribute on non-attributes

cc216e8

Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually.

jrafanie force-pushed the rails71 branch from 72581af to 1b0c5a9 Compare November 20, 2024 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Rails71 #23225

[WIP] Rails71 #23225

jrafanie commented Oct 7, 2024

miq-bot commented Nov 20, 2024

[WIP] Rails71 #23225

Are you sure you want to change the base?

[WIP] Rails71 #23225

Conversation

jrafanie commented Oct 7, 2024

miq-bot commented Nov 20, 2024