-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Make space manager and super spaces managers allowed to publish …
…news - MEED-7471 - Meeds-io/meeds#2385 (#227) Prior to this change, the space administrator and the super space manager wasn't able to publish news in a space. This rule was specific to News management. This change will align the ACL rules to be the same as other CMS applications and tools.
- Loading branch information
Showing
5 changed files
with
185 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
content-service/src/test/java/io/meeds/news/utils/NewsUtilsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /** | ||
| * This file is part of the Meeds project (https://meeds.io/). | ||
| * | ||
| * Copyright (C) 2020 - 2024 Meeds Association [email protected] | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
| package io.meeds.news.utils; | ||
|
|
||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.mockito.Mockito.lenient; | ||
| import static org.mockito.Mockito.mockStatic; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import org.junit.AfterClass; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockedStatic; | ||
| import org.mockito.junit.MockitoJUnitRunner; | ||
|
|
||
| import org.exoplatform.commons.utils.CommonsUtils; | ||
| import org.exoplatform.services.security.Identity; | ||
| import org.exoplatform.social.core.space.model.Space; | ||
| import org.exoplatform.social.core.space.spi.SpaceService; | ||
|
|
||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class NewsUtilsTest { | ||
|
|
||
| private static final MockedStatic<CommonsUtils> COMMONS_UTILS = mockStatic(CommonsUtils.class); | ||
|
|
||
| @Mock | ||
| private SpaceService spaceService; | ||
|
|
||
| @Mock | ||
| private Space space; | ||
|
|
||
| @Mock | ||
| private Identity userAclIdentity; | ||
|
|
||
| @Mock | ||
| private Identity adminAclIdentity; | ||
|
|
||
| @AfterClass | ||
| public static void afterRunBare() throws Exception { // NOSONAR | ||
| COMMONS_UTILS.close(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCanPublishNews() { | ||
| when(userAclIdentity.getUserId()).thenReturn("user"); | ||
| when(space.getId()).thenReturn("2"); | ||
|
|
||
| assertFalse(NewsUtils.canPublishNews(null, null)); | ||
| COMMONS_UTILS.when(() -> CommonsUtils.getService(SpaceService.class)).thenReturn(spaceService); | ||
| assertFalse(NewsUtils.canPublishNews(space.getId(), null)); | ||
| assertFalse(NewsUtils.canPublishNews(space.getId(), userAclIdentity)); | ||
|
|
||
| when(spaceService.getSpaceById(space.getId())).thenReturn(space); | ||
|
|
||
| assertFalse(NewsUtils.canPublishNews(space.getId(), null)); | ||
| assertFalse(NewsUtils.canPublishNews(space.getId(), userAclIdentity)); | ||
|
|
||
| when(adminAclIdentity.isMemberOf(NewsUtils.PLATFORM_WEB_CONTRIBUTORS_GROUP, NewsUtils.PUBLISHER_MEMBERSHIP_NAME)).thenReturn(true); | ||
| assertTrue(NewsUtils.canPublishNews(space.getId(), adminAclIdentity)); | ||
| assertFalse(NewsUtils.canPublishNews(space.getId(), userAclIdentity)); | ||
|
|
||
| lenient().when(spaceService.isMember(space, userAclIdentity.getUserId())).thenReturn(true); | ||
| assertFalse(NewsUtils.canPublishNews(space.getId(), userAclIdentity)); | ||
| lenient().when(spaceService.isMember(space, userAclIdentity.getUserId())).thenReturn(false); | ||
|
|
||
| when(spaceService.isPublisher(space, userAclIdentity.getUserId())).thenReturn(true); | ||
| assertTrue(NewsUtils.canPublishNews(space.getId(), userAclIdentity)); | ||
| when(spaceService.isPublisher(space, userAclIdentity.getUserId())).thenReturn(false); | ||
|
|
||
| when(spaceService.isManager(space, userAclIdentity.getUserId())).thenReturn(true); | ||
| assertTrue(NewsUtils.canPublishNews(space.getId(), userAclIdentity)); | ||
| when(spaceService.isManager(space, userAclIdentity.getUserId())).thenReturn(false); | ||
|
|
||
| when(spaceService.isSuperManager(userAclIdentity.getUserId())).thenReturn(true); | ||
| assertTrue(NewsUtils.canPublishNews(space.getId(), userAclIdentity)); | ||
| } | ||
|
|
||
| } |