Adapt to Coq PR #18795 (more uniform API for declare.ml) #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
herbelin
changed the title
herbelin
force-pushed
the
main+adapt-coq-pr18795-more-uniform-declare.ml
branch
from
46fd47f to
9a28be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By uniformity, and to ensure awareness of what opacity is chosen, coq/coq#18795 proposes that opaque is now made a mandatory label of
add_definition, like it is for other declaration functions of the API.The label
termis also renamed tobody, again by consistency of naming.To be merged synchronously with coq/coq#18795.