-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nf
in inverse matching
#312
Conversation
Could you also provide a unit test? |
Btw, at this point it should not be worth to define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no brilliant idea for any unit test in the short term, the benchmark is definitely good enough.
We can merge.
Thanks, indeed I had not a brilliant idea for a unit test, as this bug was mostly visible at PDF level. |
I do have some idea (call |
Somehow the
nf
passed during the inverse matching is not correct:see:
eko/src/eko/runner/parts.py
Line 152 in 50f108f
This can be fixed by setting always: