Don't change the input variable when checking old-new for DW datasets #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the exact check we want
(_DW_, legacy)to matchlegacy_dw. We were doing this by modifyingvariant_usedinstead ofvariant.I found this while looking for possible issues that could mess up the makereplica test, I don't know whether it is related (the NMC loaded in that test had the wrong legacy name, but it is the second one while the seed in make replica is set with the first... but maybe every now and then the order changes?). This is one of the things that will be modified in #2156 btw.
In any case, this is a somewhat trivial bug that this fixes.