Hydrofabric refactor to support latest hydrofabric data model #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellkite500
force-pushed
the
hydrofabric-refactor
branch
from
93ae187 to
1b2fd81
Compare
program--
requested changes
Nov 1, 2023
hellkite500
force-pushed
the
hydrofabric-refactor
branch
from
92eaa39 to
e430048
Compare
program--
approved these changes
Nov 1, 2023
PhilMiller
reviewed
Nov 9, 2023
|
|
||
| destinations = network.get_destination_ids(feat_id); | ||
| if(feat_type == "cat" || feat_type == "agg") |
There was a problem hiding this comment.
I just noticed - this same change (and the one below in else if) should have been made for HY_Features_MPI as well.
PhilMiller
added a commit
to PhilMiller/NOAA-OWP-ngen
that referenced
this pull request
Nov 9, 2023
10 tasks
hellkite500
pushed a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle latest stable hydrofabric representations based on the hydrfabric datamodel.
Closes #619 #649
I believe this also address some of the segmentation faults reported, and I expect this to resolve
#658
CIROH-UA/NGIAB-CloudInfra#21
Since the segfault (based on the valgrind backtrace in #658) is showing the fault happening when accessing a nexus (that was a nullptr). This PR should prevent that nexus from being null, and if it is, should should throw an approriate runtime error.
Allows #604 and #659 to be addressed by simply doing
collection.update_ids("id");after the nexus and catchment collections are read and combined (in whatever format)
This may partially and/or indirectly address #529
Additions
hy_features::identifiersnamespace with static representations of hydrofabric feature identity prefixes and some helper functions for determining if an identifier represents a particular concept.Removals
Changes
FeatureCollectionto maintain an identity map for an alternate id, e.g. bothdivide_idandidTesting
Todos
Feature::get_id(const std::string& alt_id)and FeatureCollectionupdate_ids( const std::string& alt_id )Checklist
Target Environment support