Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HY_Features_MPI to match feature-type behavior of HY_Features from PR #665 #674

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Nov 9, 2023

#665 modified HY_Features.cpp to use predicate functions that recognize a broader set of identifier prefixes to describe catchments and nexuses. The corresponding change to the mostly-duplicate code in HY_Features_MPI was not made, so I do that here.

Changes

  • Use isCatchment() and isNexus() predicate functions

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@hellkite500
Copy link
Member

I didn't implement this prior due to the refactor I proposed in #668. I haven't had a chance to come back to that, so thanks for putting this in in the mean time.

@hellkite500 hellkite500 merged commit c92dc93 into NOAA-OWP:master Nov 9, 2023
17 of 19 checks passed
@PhilMiller PhilMiller deleted the mpi-duplication-bugfix branch November 10, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants