-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use collection-2021-1.0 conda env for tests #10
base: master
Are you sure you want to change the base?
Conversation
Actually, it's not that trivial to test the tab-completion programmatically. @jklynch, any idea about that? The failed test was due to another reason. |
Maybe we have to be satisfied with triggering the error some way other than tab completion, and trying to recognize the specific exception. |
It makes no sense to me, but it really looks like there is a colon missing from the PV that is causing the current failure. Should there be a |
That worked fine with |
We had to downgrade pyepics from 3.4.0 to 3.3.0 for a similar problem I think. That may have been two deployments ago, so it might not be relevant any more. |
Is it possible to add a |
Oh, good eye! Looks like it can cause trouble. I wonder why the responses were successful in prior files, before 26-...
Yes, I specifically added this line some time ago to support such drop-in requests/tests: |
Well, that drop-in.py file will not be executed, as it will fail earlier. I'll add another .sh file to support it. |
This error may be a sign of deeper issues. Today at SRX I discovered the non-existent PVs were still a part of the class, which did not fail in the previous versions of ophyd for some reason, but failed with the currently deployed version 1.6.0 (see NSLS-II-SRX/profile_collection#24). I guess the class may need the updated |
Here is the update to run against the
collection-2021-1.0
conda environment.Expected outcomes:
--IPCompleter.use_jedi=False
option, see https://github.com/NSLS-II/playbooks/pull/411), we should see the successful test.