-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.17.4 to production #439
Conversation
jackiequach
commented
Sep 7, 2023
•
edited
Loading
edited
- Add id as subsection for "Read Online" CTA analytics tracking
- Verify advance search filters for DRB
- Verify "read online only" toggle button on item details page
- Verify the headers and footers of Advanced Search page
- Verify the footers and the respecting landing pages (homepage)
- Verify the Back to Search Results button is available on Item Details page
- Verify the header links of home page
- Add Playwright tests to GitHub Actions
- Fix Playwright test failures
- Upgrade New Relic packages and update configuration
- Update Adobe Analytics page names
SFR-1739: Analytics - add id as subsection
…utton Sfr 1746/item details page toggle button
* SFR-1743/advance-search-language-filter * change the button mapping at feature file
* Preparing branch * Created headerLinks.feature and added My Account checks * Reformatted scenario steps into data tables * Partially filled out header data table * Added remaining header links and mappings * Fixed lint errors * Fixed remaining lint errors
* added to changelog * added language filter test * update changelog * removed stray console.log * added playwright yml * typo * playwright gha * playwright env * yml * yml * yaml * yml * added headless is true in setup.ts * minor edit to yml file * Added Slack notification step * Uncommented cron and added Cucumber env * Added run options * Deleted cucumber.js since cucumber.json already exists * Uncommented Cucumber publish * Updated run schedule * Uncommented push to test Slack notif * Added feature folder to command line * Commented out push and waiting till notif on schedule * Removed run on push * Updated changelog --------- Co-authored-by: Chris Mulholland <[email protected]>
SFR-1753: Update New Relic configuration
SFR-1762: Update Adobe Analytic page names
NOREF prepare 0.17.4 release
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Playwright end-to-end tests failed, I'd like to understand why before we deploy. Can we get QA to run those tests and/or do some manual testing on QA to confirm everything looks ok?
* Adjusted mappings * Fixed most errors in itemDetailPageElements * Didn't see issue with resolved to 2 elements but specified first Jane Austen link * Didn't see issue with resolved to 2 elements but specified first robot soccer link * Corrected ticket number in changelog * Fixed lint error * Fixed capitalization of mappings in advSearch * Removed unneeded element
@clarissarichard Sorry this is probably confusing, but since this is a prod release PR, we need to first make the test fixes on the development branch in order to keep the commits in sync between development branch and production branch. For now, can you make a new PR off the development branch with your changes? Also I want to be clear that these tests don't need to be fixed in order to make a production release. I just need QA to do some manual testing to confirm that everything is working as expected on the QA site. I don't want @clarissarichard to feel like fixing these tests is blocking a prod launch, because that's definitely not the case. @jackiequach can you revert Clarissa's last commit on this branch? If we get a fix for these tests in development, you can pull them into this branch and include them in the Prod release. |
@samanthaandrews The commit was a PR merged into the development branch. We can push this release to Monday. |
@jackiequach @clarissarichard I'm losing my mind! Thank you for the clarification. You did everything right, I just can't read commits 😢 |
* Added Deprecated message to README * Removed rspec workflow yml file