Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete LiveUX. #412

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Remove obsolete LiveUX. #412

merged 2 commits into from
Oct 25, 2024

Conversation

nc-andreashaller
Copy link
Collaborator

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 25, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 25, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

jonatan-lledo-netcentric
jonatan-lledo-netcentric approved these changes Oct 25, 2024
View reviewed changes
README.md
@@ -20,6 +20,6 @@ npm tst
## Local development

1. Clone this repository
1. Install the [Helix CLI](https://github.com/adobe/helix-cli): `npm install -g @adobe/helix-cli`
1. Start Helix Pages Proxy: `hlx up` (opens your browser at `http://localhost:3000`)
1. Install the [AEM CLI](https://github.com/adobe/helix-cli): `npm install -g @adobe/aem-cli`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this could be confusing but the project is still called helix-cli even if the npm package now is aem-cli

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but they did not rename the repo :D

@nc-andreashaller nc-andreashaller merged commit 1975148 into main Oct 25, 2024
2 checks passed
@nc-andreashaller nc-andreashaller deleted the remove-liveux branch October 25, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatan-lledo-netcentric jonatan-lledo-netcentric jonatan-lledo-netcentric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nc-andreashaller @jonatan-lledo-netcentric