Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete LiveUX. #412

Merged
merged 2 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ Please always provide the [GitHub issue(s)](../issues) your PR is for, as well a
Fix #<gh-issue-id>

Test URLs:
- Before: https://main--cn-website--netcentric.hlx.page/
- After: https://<branch>--cn-website--netcentric.hlx.page/
- Before: https://main--cn-website--netcentric.aem.live/
- After: https://<branch>--cn-website--netcentric.aem.live/
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Relaunch of the [netcentric.biz](https://www.netcentric.biz) website.

## Environments
- Preview: https://main--cn-website--netcentric.hlx.page
- Live: https://main--cn-website--netcentric.hlx.live/
- Preview: https://main--cn-website--netcentric.aem.page
- Live: https://main--cn-website--netcentric.aem.live

## Installation

Expand All @@ -20,6 +20,6 @@ npm tst
## Local development

1. Clone this repository
1. Install the [Helix CLI](https://github.com/adobe/helix-cli): `npm install -g @adobe/helix-cli`
1. Start Helix Pages Proxy: `hlx up` (opens your browser at `http://localhost:3000`)
1. Install the [AEM CLI](https://github.com/adobe/helix-cli): `npm install -g @adobe/aem-cli`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this could be confusing but the project is still called helix-cli even if the npm package now is aem-cli

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but they did not rename the repo :D

1. Start AEM Pages Proxy, execute while being in `cn-website`: `aem up` (opens your browser at `http://localhost:3000`)
1. Open the `cn-website` directory in your favorite IDE and start coding :)
2 changes: 1 addition & 1 deletion plugins/experimentation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ runEager.call(document, {
// (prod environments do not get the pill overlay)
prodHost: 'www.my-website.com',
// if you have several, or need more complex logic to toggle pill overlay, you can use
isProd: () => window.location.hostname.endsWith('hlx.page')
isProd: () => window.location.hostname.endsWith('aem.page')
|| window.location.hostname === ('localhost'),

/* Generic properties */
Expand Down
2 changes: 1 addition & 1 deletion plugins/experimentation/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ export async function loadLazy(document, options, context) {
...DEFAULT_OPTIONS,
...(options || {}),
};
if (window.location.hostname.endsWith('hlx.page')
if (window.location.hostname.endsWith('aem.page')
|| window.location.hostname === ('localhost')
|| (typeof options.isProd === 'function' && !options.isProd())
|| (options.prodHost && options.prodHost !== window.location.origin)) {
Expand Down
6 changes: 0 additions & 6 deletions scripts/delayed.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ function loadLaunch() {
injectScript(src);
}

function loadLiveUXRUM() {
const src = 'https://liveux.cnwebperformance.biz/collector/collector.min.js?id=webperf-netcentric';
injectScript(src, 'anonymous');
}

function loadSidekickExtension() {
injectScript('/scripts/sidekick.js');
}
Expand Down Expand Up @@ -84,7 +79,6 @@ class ScrollIndicator {

decorateTwitterFeed();
loadLaunch();
loadLiveUXRUM();
loadSidekickExtension();

if (document.body.classList.contains('blogpost')) {
Expand Down
4 changes: 2 additions & 2 deletions scripts/lib-franklin.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function sampleRUM(checkpoint, data = {}) {
const sendPing = (pdata = data) => {
// eslint-disable-next-line object-curly-newline, max-len, no-use-before-define
const body = JSON.stringify({ weight, id, referer: window.location.href, generation: window.hlx.RUM_GENERATION, checkpoint, ...data });
const url = `https://rum.hlx.page/.rum/${weight}`;
const url = `https://rum.aem.page/.rum/${weight}`;
// eslint-disable-next-line no-unused-expressions
navigator.sendBeacon(url, body);
// eslint-disable-next-line no-console
Expand All @@ -62,7 +62,7 @@ export function sampleRUM(checkpoint, data = {}) {
lazy: () => {
// use classic script to avoid CORS issues
const script = document.createElement('script');
script.src = 'https://rum.hlx.page/.rum/@adobe/helix-rum-enhancer@^1/src/index.js';
script.src = 'https://rum.aem.page/.rum/@adobe/helix-rum-enhancer@^1/src/index.js';
document.head.appendChild(script);
return true;
},
Expand Down
Loading