Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add failongiterror as parameter to report any git error as NuKeeper e… #1140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinDemberger
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

A new option is added. When the option FailOnGitError is set the run failes when the call to get the available versions failes.

This is only the first part of a fix for #930

⤵️ What is the current behavior?

On most of git calls the error is ignored and NuKeeper notifies success.

🆕 What is the new behavior (if this is a feature change)?

A new option --failongiterror is introduced and when this option is set an error in a git call results in an error of NuKeeper.

In the current process the option is only used when searching for the available package versions.

💥 Does this PR introduce a breaking change?

No, the default behaviour is unchanged.

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Relevant documentation was updated

@MartinDemberger MartinDemberger mentioned this pull request Sep 21, 2021
2 tasks
@stale
Copy link

stale bot commented Dec 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants