Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultModelManager adoption #163

Merged
merged 17 commits into from
Jun 15, 2024
Merged

ResultModelManager adoption #163

merged 17 commits into from
Jun 15, 2024

Conversation

anthonysena
Copy link
Collaborator

Aims to add the ResultModelManager package for results schema management and upload capabilities. This PR will address #154 and #162.

Additional notes:

  • Added new test cohort to ensure we have the ability to test a cohort with censor stats. This is needed to test 2 things: the addition of the database_id to the cohort_censor_stats table per Results data model extensions #162 and the migration of the data model.

Outstanding items:

  • Need to revise the resultsDataModelSpecification.csv to include the changes made in the migration.
  • Need to add test data to test the upload
  • May also add a single "runCohortGeneration" function to allow for the full set of functionality for generating cohorts in a single pass.
  • Add the ability to export cohort subset definitions to ensure the upload of this new data works as expected.
  • Test cases for the above.

@anthonysena anthonysena marked this pull request as ready for review June 15, 2024 15:51
@anthonysena anthonysena merged commit cad2c9d into develop Jun 15, 2024
14 checks passed
@anthonysena anthonysena deleted the rmm-work branch July 14, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results data model extensions Move resultsDataModelSpecification.csv into package and use RMM for migrations
1 participant