tests: showcase bug 7286 (tls) - v2 #2073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorjulien
reviewed
Oct 3, 2024
| tls.version: TLS 1.2 | ||
| tls.notbefore: '2015-02-12T18:07:27' | ||
| tls.notafter: '2025-02-09T18:07:27' | ||
| tls.certificate: MIIDazCCAlOgAwIBAgIJAJfmRwmO6sm0MA0GCSqGSIb3DQEBBQUAMEwxCzAJBgNVBAYTAkZSMQwwCgYDVQQIDANJREYxDjAMBgNVBAcMBVBhcmlzMQ8wDQYDVQQKDAZTdGFtdXMxDjAMBgNVBAMMBVNFTEtTMB4XDTE1MDIxMjE4MDcyN1oXDTI1MDIwOTE4MDcyN1owTDELMAkGA1UEBhMCRlIxDDAKBgNVBAgMA0lERjEOMAwGA1UEBwwFUGFyaXMxDzANBgNVBAoMBlN0YW11czEOMAwGA1UEAwwFU0VMS1MwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCmgr7oVpNtYfdPyUd3zeU8fI0NuhU09a4ehajW2jNtX/1iU/pF8F2EdCeHcTJkPJb/85S/vwJQpYR3WI41zfDzJGmU53uT2DV62rL5Tg8kvgEJ4/L2S+7lk5ksdwy07fVV39qy6leKvfIw85LL45dnUsK8ITkuXckXO/fWM+1hPwhbQTRKT7aQqo6XiVt1EoM2GYANe396rjLRX91rR+paQVAEF4XEx511RYepdLMm+WUBHfCGAU6+MKV21OhFdo9ec3z+d6V+YvQEPDQOS/Xv9pqRKL8C1G4C/+VlLZBwenL9pwRUkgLiiAeYJ1k2+Zg+2UfrE37a+hIqHIU2RgwDAgMBAAGjUDBOMB0GA1UdDgQWBBRqzuaHms84l/2BqOJ5lY8a3qsiIjAfBgNVHSMEGDAWgBRqzuaHms84l/2BqOJ5lY8a3qsiIjAMBgNVHRMEBTADAQH/MA0GCSqGSIb3DQEBBQUAA4IBAQBWjesA1fAyOyHeWw8g+6k+6uhWIVR597qzU9H29lnhygD6xSPfppisSDAj1sNGqVbRC45NR3QehYdkvfRMtXREoKjhbKPDA8KAmcHOiWC9pLbxRbmY1bIB0kVw3BLIF1/y7gADwL8L4p/rm+M8Q6upWQtEqP+S8rI45iMr1CYEiZY3lU7B8byObgXv8S6372osD7+w09L57uLzEwMz+lL2vLLllPkf3B7VqqzvC8W/7PkUVmk5dUWN0f2kbx2iYOlglGC4zBSH8ThKDPMJbKMBzgP+DhdGcrWB89EbUCSY1IDmcJ4dhDgP/E78lTt2kHKLUws9pbktzW3EqUvWw6hF |
There was a problem hiding this comment.
are these large blobs needed to show the issue? If so, please put them in quotes. If not, lets remove them for a cleaner test.
There was a problem hiding this comment.
Should I split this into two different PRs:
- one test for TLS metadata in TLS events (and then I remove
tls.certificateandtls.chainfrom these tests), which could be merged as is, I assume - one test for custom TLS fields in EVE log (and then adding
tls.certificateandtls.chain, with quotes.) - which will require merging of the schema fixing PR first.
The advantage of this is allowing for the SV test for bug 7286 to be merged faster.
|
Replaced by #2077 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Bug https://redmine.openinfosecfoundation.org/issues/7286
This also exposes https://redmine.openinfosecfoundation.org/issues/7287 and thus requires that OISF/suricata#11844 is merged, not to break SV for master
Describe changes:
min-version: 8for CI checks for 7 to passTicket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7286