Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: showcase bug 7286 (tls) - v3 #2077

Closed
wants to merge 1 commit into from

Conversation

jufajardini
Copy link
Contributor

Related to
Bug https://redmine.openinfosecfoundation.org/issues/7286

Previous PR: #2073

Changes from last PR:

  • remove TLS custom fields that are not yet present in our schema, so these can be merged independently of the schema fix

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7286

@jufajardini jufajardini added the tests pass These new tests should pass label Oct 5, 2024
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's pcap files accidentally checked in even though the tests don't use it.

@jufajardini
Copy link
Contributor Author

There's pcap files accidentally checked in even though the tests don't use it.

🥲 sorry about that. fixing now.

@jufajardini
Copy link
Contributor Author

Replaced by: #2096

@jufajardini jufajardini deleted the bug-7286-sv/v3 branch October 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests pass These new tests should pass
Development

Successfully merging this pull request may close these issues.

2 participants