test: add test for vlan.id - v4 #2176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AkakiAlice I added the label |
catenacyber
reviewed
Dec 11, 2024
| @@ -0,0 +1,2 @@ | |||
| alert ip any any -> any any (msg:"Vlan ID is equal to 200 with specific layer"; vlan.id:200,1; sid:1;) | |||
There was a problem hiding this comment.
Should it be vlan.id:200,0; as we see vlan[0]: 200
catenacyber
reviewed
Dec 11, 2024
| @@ -0,0 +1,3 @@ | |||
| Test for checking the working of vlan.id keyword by creating rules and matching a crafted packet against them. The packet is an ICMP packet with 3 different VLAN ids [200,300,400]. | |||
|
|
|||
| PCAP created with scapy. | |||
There was a problem hiding this comment.
You can include the scapy script in the PR
There was a problem hiding this comment.
When you do so, please also include the scapy version used, as things sometimes change from version to version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1065
Description:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1065
Previous PR: #2134