Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for vlan.id - v4 #2176

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/detect-vlan-id/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Test for checking the working of vlan.id keyword by creating rules and matching a crafted packet against them. The packet is an ICMP packet with 3 different VLAN ids [200,300,400].

PCAP created with scapy.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can include the scapy script in the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you do so, please also include the scapy version used, as things sometimes change from version to version

Binary file added tests/detect-vlan-id/input.pcap
Binary file not shown.
2 changes: 2 additions & 0 deletions tests/detect-vlan-id/test.rules
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
alert ip any any -> any any (msg:"Vlan ID is equal to 200 with specific layer"; vlan.id:200,1; sid:1;)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be vlan.id:200,0; as we see vlan[0]: 200

alert ip any any -> any any (msg:"Vlan ID is equal to 400"; vlan.id:400; sid:2;)
19 changes: 19 additions & 0 deletions tests/detect-vlan-id/test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
requires:
min-version: 8

args:
- -k none

checks:
- filter:
count: 1
match:
event_type: alert
vlan[0]: 200
alert.signature_id: 1
- filter:
count: 1
match:
event_type: alert
vlan[2]: 400
alert.signature_id: 2
Loading